Skip to content

Conversation

@metamaskbot
Copy link
Collaborator

@metamaskbot metamaskbot commented Nov 24, 2025

This PR syncs the stable branch to main for version 13.10.2.

Synchronization Process:

  • Fetches the latest changes from the remote repository
  • Resets the branch to match the stable branch
  • Attempts to merge changes from main into the branch
  • Handles merge conflicts if they occur

File Preservation:

Preserves specific files from the stable branch:

  • CHANGELOG.md
  • bitrise.yml
  • android/app/build.gradle
  • ios/MetaMask.xcodeproj/project.pbxproj
  • package.json

Indicates the next version candidate of main to 13.10.2


Note

Updates CHANGELOG to add 13.10.2 with a fix for entry modal close error and refreshes compare links.

Written by Cursor Bugbot for commit 5962751. This will update automatically on new commits. Configure here.

metamaskbot and others added 6 commits November 24, 2025 15:16
This PR updates the change log for 13.10.2. (Hotfix - no test plan
generated.)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> <sup>[Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) is
generating a summary for commit
8f459a0. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: metamaskbot <metamaskbot@users.noreply.github.com>
Co-authored-by: Gauthier Petetin <gauthierpetetin@hotmail.com>
…3.11.0 cp-13.10.2 (#38197)

- fix: fixed entry modal closed error cp-13.11.0 (#38188)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR fixed entry modal closed error.

[![Open in GitHub

Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/38188?quickstart=1)

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: fixed entry modal closed error

## **Related issues**

Fixes: #38096

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding

Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling

guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Wrap `onClose` handlers in `ShieldEntryModal` with callbacks to call
`handleOnClose()` directly, preventing close errors.
> 
> - **UI**:
>   - In `ui/components/app/shield-entry-modal/shield-entry-modal.tsx`:
> - Update `Modal` and `ModalHeader` `onClose` props from
`onClose={handleOnClose}` to `onClose={() => handleOnClose()}` to ensure
proper invocation without unintended arguments.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
5b4a45e. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->


[e7f54a4](e7f54a4)

Co-authored-by: Lwin <147362763+lwin-kyaw@users.noreply.github.com>
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Nov 24, 2025
@metamaskbot
Copy link
Collaborator Author

Builds ready [5962751]
UI Startup Metrics (1255 ± 112 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12551041153511213461450
load1070877129910011541252
domContentLoaded106387212949911381240
domInteractive2715125242297
firstPaint53196123340210191166
backgroundConnect2151972529219236
firstReactRender30206993447
getState342096124054
initialActions104112
loadScripts8566791090999311045
setupStore1173341221
numNetworkReqs1257720572
BrowserifyPower User HomeuiStartup18421560271418519522149
load97687617951539561396
domContentLoaded96386617831539421388
domInteractive37162064129160
firstPaint56815017884069281416
backgroundConnect21619624810223237
firstReactRender84431492194130
getState16712723824183224
initialActions107113
loadScripts76167015461507401171
setupStore2311168202452
numNetworkReqs1336630455176272
WebpackStandard HomeuiStartup811693106779845991
load63156184065652787
domContentLoaded62655283565649782
domInteractive28151602721106
firstPaint20786648119209584
backgroundConnect1053851218
firstReactRender271979103238
getState271365123649
initialActions103112
loadScripts62455082564646772
setupStore1163451322
numNetworkReqs1257320572
WebpackPower User HomeuiStartup14201100173713415311674
load6675831081100668946
domContentLoaded6575761076101655940
domInteractive37181813633145
firstPaint277861087207269660
backgroundConnect1566271629
firstReactRender81401121593100
getState1485819217158173
initialActions103012
loadScripts655574106699653931
setupStore21953132748
numNetworkReqs1446730455188296
FirefoxBrowserifyStandard HomeuiStartup11831063148910712351416
load99190711937410281170
domContentLoaded99090611877410231169
domInteractive51292323254131
firstPaint------
backgroundConnect321894133562
firstReactRender21174452134
getState96465920
initialActions102112
loadScripts97188811777010101135
setupStore10415916822
numNetworkReqs1156815655
BrowserifyPower User HomeuiStartup24031978327324625682886
load1135923183417011751523
domContentLoaded1134920183417111751523
domInteractive12631859124119412
firstPaint------
backgroundConnect982847161112202
firstReactRender84411832195124
getState29550842231466769
initialActions207127
loadScripts1101903181216411331438
setupStore106777014689474
numNetworkReqs925821036127165
WebpackStandard HomeuiStartup14201245190613114531722
load1202104514649212601374
domContentLoaded1202104514639212591374
domInteractive49261863067113
firstPaint------
backgroundConnect42181962642104
firstReactRender26197062734
getState125126141240
initialActions103112
loadScripts1179102914398612351340
setupStore175148251384
numNetworkReqs1156616661
WebpackPower User HomeuiStartup27052196338124428353166
load14071182197017314581772
domContentLoaded14071182196917314581772
domInteractive11929583113110472
firstPaint------
backgroundConnect1183064194125306
firstReactRender83391281694110
getState24375889205301682
initialActions4171737
loadScripts13651150194216614171744
setupStore121678717885650
numNetworkReqs926121234121152
📊 Page Load Benchmark Results

Current Commit: 5962751 | Date: 11/24/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±42ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 732ms (±37ms) 🟢 | historical mean value: 719ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±13ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 42ms 1.02s 1.35s 1.08s 1.35s
domContentLoaded 732ms 37ms 704ms 1.00s 754ms 1.00s
firstPaint 79ms 13ms 64ms 196ms 88ms 196ms
firstContentfulPaint 79ms 13ms 64ms 196ms 88ms 196ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@gauthierpetetin gauthierpetetin merged commit 5764962 into main Nov 25, 2025
86 of 87 checks passed
@gauthierpetetin gauthierpetetin deleted the stable-main-13.12.0 branch November 25, 2025 05:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 25, 2025
@gauthierpetetin gauthierpetetin changed the title release: sync stable to main for version 13.12.0 release: sync stable to main for version 13.10.2 Nov 25, 2025
@metamaskbot metamaskbot added the release-13.12.0 Issue or pull request that will be included in release 13.12.0 label Nov 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.12.0 Issue or pull request that will be included in release 13.12.0 size-XS team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants