fix: Update recipient placeholder text in send flow #38236
Merged
+6
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +1 -1)
🧪 @MetaMask/qa (1 files, +1 -1)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
dan437
reviewed
Nov 25, 2025
| "recipientPlaceholder": { | ||
| "message": "Enter or paste a valid address" | ||
| "recipientPlaceholderText": { | ||
| "message": "Enter or paste an address or name" |
There was a problem hiding this comment.
Bug: Missing translation key in non-English locale files
The translation key was renamed from recipientPlaceholder to recipientPlaceholderText in English locale files and the component code, but all other locale files (German, Spanish, French, Greek, Irish, etc.) still use the old key name. This causes the placeholder text to break for non-English users since the translation system cannot find recipientPlaceholderText in their locale files.
dan437
approved these changes
Nov 25, 2025
There was a problem hiding this comment.
Bug: Missing translation key in non-English locales
The translation key recipientPlaceholderText was added only to English locales but not to non-English locales (de, el, es, fr, ga, hi, id, ja, ko, pt, ru, tl, tr, vi, zh_CN). The code in recipient-input.tsx now references t('recipientPlaceholderText'), but this key doesn't exist in most locale files. Users with non-English language settings will see broken placeholder text or fallback behavior instead of properly translated text.
app/_locales/de/messages.json#L4989-L4999
metamask-extension/app/_locales/de/messages.json
Lines 4989 to 4999 in 993e27c
app/_locales/es/messages.json#L4989-L4999
metamask-extension/app/_locales/es/messages.json
Lines 4989 to 4999 in 993e27c
app/_locales/fr/messages.json#L4989-L4999
metamask-extension/app/_locales/fr/messages.json
Lines 4989 to 4999 in 993e27c
Collaborator
Builds ready [993e27c]
UI Startup Metrics (1237 ± 97 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [db9bea1]
UI Startup Metrics (1263 ± 130 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Bug: Missing translation key in non-English locales
The translation key recipientPlaceholder was removed from all non-English locales (de, el, es, fr, ga, hi, id, ja, ko, pt, ru, tl, tr, vi, zh_CN) but the new key recipientPlaceholderText wasn't added to these files. The code now references recipientPlaceholderText, which only exists in English locales, causing the placeholder text to be missing or display incorrectly for users in non-English languages.
app/_locales/de/messages.json#L4996-L4997
metamask-extension/app/_locales/de/messages.json
Lines 4996 to 4997 in 10c0ddb
app/_locales/es/messages.json#L4996-L4997
metamask-extension/app/_locales/es/messages.json
Lines 4996 to 4997 in 10c0ddb
app/_locales/fr/messages.json#L4996-L4997
metamask-extension/app/_locales/fr/messages.json
Lines 4996 to 4997 in 10c0ddb
Collaborator
Builds ready [10c0ddb]
UI Startup Metrics (1333 ± 131 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.13.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to update placeholder text in send flow recipient component.
Changelog
CHANGELOG entry: Update recipient placeholder text in send
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6257
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Updates recipient input placeholder to support addresses or names, with i18n key changes and e2e selector update.
recipient-input.tsx: Switches placeholder tot('recipientPlaceholderText')("Enter or paste an address or name").recipientPlaceholderacross locales.recipientPlaceholderTextinapp/_locales/en/messages.jsonanden_GBwith updated copy.send-page.ts: Update input selector to new placeholder text.Written by Cursor Bugbot for commit 10c0ddb. This will update automatically on new commits. Configure here.