fix: Update dapp swap comparison banner copy if rewards doesnt exist #38317
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGPoyraz
added
the
no-changelog
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (2 files, +3 -2)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| }); | ||
| const { getByText } = render(); | ||
| expect(getByText(/Earn 100 points/u)).toBeInTheDocument(); | ||
| expect(getByText('Save and earn with MetaMask Swaps')).toBeInTheDocument(); |
There was a problem hiding this comment.
Bug: Test missing mock setup prevents component from rendering
The new test 'renders rewards text when it is provided' mocks useDappSwapComparisonRewardText to return rewards data, but doesn't mock useDappSwapComparisonInfo with a selectedQuoteValueDifference value. The default mock only provides selectedQuote, so selectedQuoteValueDifference is undefined. The component's render condition requires selectedQuoteValueDifference >= 0.01, which fails for undefined, causing the component to not render. The test assertions checking for "Save and earn with MetaMask Swaps" will fail.
vinistevam
approved these changes
Nov 26, 2025
Collaborator
Builds ready [31dea0b]
UI Startup Metrics (1234 ± 135 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
dan437
approved these changes
Nov 27, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.12.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates dapp swap comparison banner copy if rewards does not exists.
Note: No changelog needed as this feature not released yet.
Changelog
CHANGELOG entry: null
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6349
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Shows "Save with MetaMask Swaps" when rewards are absent, adding i18n keys and updating tests accordingly.
dapp-swap-comparison-banner.tsxto rendert('dappSwapAdvantage')only whenrewardsexist; otherwise uset('dappSwapAdvantageSaveOnly').dappSwapAdvantageSaveOnlylocale string inapp/_locales/en/messages.jsonandapp/_locales/en_GB/messages.json.dapp-swap-comparison-banner.test.tsxto check for "Save with MetaMask Swaps" without rewards and "Save and earn with MetaMask Swaps" when rewards are provided.Written by Cursor Bugbot for commit 31dea0b. This will update automatically on new commits. Configure here.