fix: sei and mon native token swap selection #38349
Merged
+48
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [47b5675]
UI Startup Metrics (1331 ± 132 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| + ChainId[ChainId["MONAD"] = 143] = "MONAD"; | ||
| })(ChainId || (exports.ChainId = ChainId = {})); | ||
| var RequestStatus; | ||
| (function (RequestStatus) { |
There was a problem hiding this comment.
Bug: Patch missing ESM version of ChainId enum
The patch only modifies dist/types.cjs (CommonJS) but likely needs to also patch dist/types.mjs (ES Modules). Other patches in this repository (e.g., @metamask-assets-controllers) patch both .cjs and .mjs files because MetaMask controller packages export both formats. If the build system resolves the ESM version, the SEI and MONAD chain IDs won't be present in the ChainId enum, and the fix for the swap field defaulting issue may not work consistently.
infiniteflower
previously approved these changes
Nov 27, 2025
khanti42
moved this from Needs dev review
to Has approvals, needs CODEOWNER
in PR review queue
Co-authored-by: Mark Stacey <mark.stacey@consensys.net>
wantedsystem
previously approved these changes
Nov 27, 2025
github-project-automation
bot
moved this from Has approvals, needs CODEOWNER
to Review finalised - Ready to be merged
in PR review queue
…ei-mon-swap-native-selection
khanti42
dismissed stale reviews from wantedsystem and infiniteflower
via
7e97b5e
| + ChainId[ChainId["MONAD"] = 143] = "MONAD"; | ||
| })(ChainId || (exports.ChainId = ChainId = {})); | ||
| var RequestStatus; | ||
| (function (RequestStatus) { |
There was a problem hiding this comment.
Bug: Patch may be incomplete, missing ESM file modification
The patch only modifies dist/types.cjs (CommonJS), but existing patches in this repository for other MetaMask controller packages (like @metamask-assets-controllers) follow a pattern of patching both .cjs and .mjs files. If @metamask/bridge-controller has dual exports (which is standard for MetaMask packages), the ESM version (types.mjs) won't include the SEI and MONAD chain IDs. This could cause the same bug to reappear in contexts that use ESM module resolution.
Collaborator
Builds ready [7e97b5e]
UI Startup Metrics (1290 ± 105 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
| + ChainId[ChainId["MONAD"] = 143] = "MONAD"; | ||
| })(ChainId || (exports.ChainId = ChainId = {})); | ||
| var RequestStatus; | ||
| (function (RequestStatus) { |
There was a problem hiding this comment.
Bug: Patch missing ESM file causing inconsistent ChainId enum
The patch only modifies dist/types.cjs (CommonJS) but likely needs to also patch dist/types.mjs (ES Module). Looking at similar patches in this codebase like @metamask-assets-controllers-npm-89.0.1-02fa7acd54.patch, MetaMask controller packages typically export both CJS and ESM formats, and both need patching for consistency. If only the CJS file is patched, code that imports via ESM bundling won't see the new SEI and MONAD chain IDs, potentially causing the fix to not work in certain module resolution contexts.
Collaborator
Builds ready [9625185]
UI Startup Metrics (1205 ± 108 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
wantedsystem
approved these changes
Nov 27, 2025
Collaborator
Builds ready [f04cda3]
UI Startup Metrics (1208 ± 94 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
n3ps
approved these changes
Nov 27, 2025
sahar-fehri
approved these changes
Nov 27, 2025
metamaskbot
added
the
release-13.12.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies a Yarn patch to @metamask/bridge-controller@61.0.0 to correctly register the MONAD (143) and SEI (1329) chain IDs in the ChainId enum.
This resolves a UI bug where swap fields incorrectly default to BTC or ETH instead of MON/SEI when all “Popular Networks” are enabled.
The bridge-controller’s internal enumerations for numerical chain Ids did not include MONAD nor SEI (chain ID 143).
When the app attempted to determine the appropriate chain, this caused fallback behavior, leading to incorrect mappings (defaulting to BTC/ETH).
Fix
Changelog
CHANGELOG entry: Fixed a bug where swapping from the Mon token page suggested ETH instead of MON when all Popular Networks were enabled. Added missing MONAD (143) and SEI (1329) chain IDs to the bridge-controller to ensure correct chain resolution.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-11-27.at.13.24.18.mov
After
Screen.Recording.2025-11-27.at.13.22.52.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Registers SEI and MONAD chain IDs in
@metamask/bridge-controller@61.0.0via a Yarn patch and updates dependencies to use the patched package.ChainId.SEI = 1329andChainId.MONAD = 143indist/types.cjsvia/.yarn/patches/@metamask-bridge-controller-npm-61.0.0-8c413c463f.patch.package.jsonandyarn.lockto the patched@metamask/bridge-controller@61.0.0.Written by Cursor Bugbot for commit f04cda3. This will update automatically on new commits. Configure here.