Skip to content

Conversation

@Qbandev
Copy link
Contributor

@Qbandev Qbandev commented Nov 27, 2025

Description

Migrates the changelog-related GitHub Actions workflows from reusable workflows to composite actions format, as required by github-tools v1.0.0+ breaking change.

Reason for the change:

  • github-tools v1.0.0 introduced a breaking change that migrated all reusable workflows to composite actions
  • The old commit SHA references (@36dc168..., @6a04e4d...) pointed to the pre-migration workflow format
  • To use v1.1.0 (which includes auto-changelog v5.2.0), we must use the new composite action format

Changes made:

Workflow Before After
create-release-pr.yml uses: .../workflows/create-release-pr.yml@SHA uses: .../actions/create-release-pr@v1.1.0
update-release-changelog.yml uses: .../workflows/update-release-changelog.yml@SHA uses: .../actions/update-release-changelog@v1.1.0

Benefits of v1.1.0:

  • Includes @metamask/auto-changelog v5.2.0 with improved commit deduplication
  • Adds deduplication for commits with no PR number in subject (non-"Squash & Merge" commits)
  • Merge commits are now deduplicated using commit body instead of the generic merge subject

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes: INFRA-3081

See: https://github.com/MetaMask/github-tools/releases/tag/v1.1.0
See: https://github.com/MetaMask/github-tools/releases/tag/v1.0.0 (breaking change)

Manual testing steps

  1. Trigger the Create Release Pull Request workflow with a test version
  2. Verify the release PR is created correctly
  3. Push to a release branch and verify the Update Release Changelog PR workflow runs

Testing Evidence

Tested in fork repository: consensys-test/metamask-extension-test

Test Status Link
update-release-changelog workflow ✅ Passed Action Run #79

Test Results:

  • Workflow successfully downloaded MetaMask/github-tools@v1.1.0
  • All input parameters passed correctly (release-branch, platform, github-tools-version: v1.1.0)
  • Repository checkout completed with full history
  • PR creation failed as expected due to fork token permissions (not a workflow issue)

Screenshots/Recordings

N/A - CI/CD workflow migration

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-dev-ops DevOps team label Nov 27, 2025
…ctions

Migrate from reusable workflows to composite actions format as per
github-tools v1.0.0 breaking change.

Updated workflows:
- create-release-pr.yml: now uses .github/actions/create-release-pr
- update-release-changelog.yml: now uses .github/actions/update-release-changelog

This update includes @metamask/auto-changelog v5.2.0 with improved
commit deduplication for changelog generation.

See: https://github.com/MetaMask/github-tools/releases/tag/v1.1.0
@Qbandev Qbandev force-pushed the chore/update-github-tools-v1.1.0 branch from dd02d04 to 2723843 Compare November 27, 2025 16:39
@github-actions github-actions bot added size-S and removed size-XS labels Nov 27, 2025
…gelog

Pin github-tools-version to v1.1.0 to prevent defaulting to 'main' branch
which could cause unpredictable behavior if main diverges.
@Qbandev Qbandev marked this pull request as draft November 27, 2025 16:43
@metamaskbot
Copy link
Collaborator

Builds ready [a153efa]
UI Startup Metrics (1321 ± 113 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup13211096158911314121507
load105987613029111081237
domContentLoaded105387212929011041229
domInteractive2716106202291
firstPaint57197126740910341210
backgroundConnect22620326513233254
firstReactRender37238393959
getState66192373577133
initialActions1012214
loadScripts8336691075898841015
setupStore1473051724
numNetworkReqs41281463332140
BrowserifyPower User HomeuiStartup20961771341526422342569
load1021895189114910161348
domContentLoaded100588818771499871332
domInteractive34171893231121
firstPaint53410918863999511283
backgroundConnect270204696125228576
firstReactRender6241124166995
getState19814471778208280
initialActions107114
loadScripts79968116641497821132
setupStore2210131152550
numNetworkReqs103672795198257
WebpackStandard HomeuiStartup87473212131039211111
load64355189980658852
domContentLoaded63854789279653844
domInteractive2715125242199
firstPaint22694899149219602
backgroundConnect1165571129
firstReactRender46221913340123
getState51141222569104
initialActions104112
loadScripts63554588277651836
setupStore1364771525
numNetworkReqs41281483330144
WebpackPower User HomeuiStartup17271310269927219602183
load6995921305109708964
domContentLoaded6895841294109694958
domInteractive36181983234141
firstPaint301941309224327731
backgroundConnect86763616824551
firstReactRender654794107184
getState19114369686187223
initialActions104112
loadScripts6865821284108691948
setupStore22854112445
numNetworkReqs1606940873208344
FirefoxBrowserifyStandard HomeuiStartup14201176190017415341777
load1095938136110111581294
domContentLoaded1095938136110111581293
domInteractive63282143389113
firstPaint------
backgroundConnect65232754970204
firstReactRender301970113552
getState2510165202546
initialActions113123
loadScripts106592413439411151275
setupStore22798152254
numNetworkReqs39281272634119
BrowserifyPower User HomeuiStartup25982045439045026483786
load1186994236018311811549
domContentLoaded1185994236018311811549
domInteractive13036532114111470
firstPaint------
backgroundConnect12526919110132325
firstReactRender6137149176496
getState25169777180305721
initialActions208124
loadScripts1138977162913511481492
setupStore16912899196180653
numNetworkReqs98602735579230
WebpackStandard HomeuiStartup15961355220517417021927
load12501082154811313201499
domContentLoaded12501082154811313201498
domInteractive60271753487120
firstPaint------
backgroundConnect60162063563140
firstReactRender322083123569
getState259206272453
initialActions204123
loadScripts12241068151910512861436
setupStore3292644223140
numNetworkReqs41281262740122
WebpackPower User HomeuiStartup29132031573770829894659
load14351137313037714012574
domContentLoaded14351136312937714012574
domInteractive1053051810096396
firstPaint------
backgroundConnect131271081169127254
firstReactRender65402082466118
getState218581055173246629
initialActions2148523
loadScripts13981095297235513762443
setupStore1626778213226656
numNetworkReqs101622475793239
📊 Page Load Benchmark Results

Current Commit: a153efa | Date: 11/27/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±52ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 721ms (±50ms) 🟢 | historical mean value: 725ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±12ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 52ms 1.00s 1.32s 1.10s 1.32s
domContentLoaded 721ms 50ms 696ms 997ms 769ms 997ms
firstPaint 75ms 12ms 56ms 176ms 84ms 176ms
firstContentfulPaint 75ms 12ms 56ms 176ms 84ms 176ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@Qbandev Qbandev requested a review from Copilot November 27, 2025 17:30
@Qbandev Qbandev changed the title chore: update github-tools to v1.1.0 for changelog workflows ci(INFRA-3081): update github-tools to v1.1.0 for changelog workflows Nov 27, 2025
Copilot finished reviewing on behalf of Qbandev November 27, 2025 17:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates changelog-related GitHub Actions workflows from reusable workflows to composite actions format, enabling the use of github-tools v1.1.0 which includes improved commit deduplication features from auto-changelog v5.2.0. The migration addresses the breaking change introduced in github-tools v1.0.0 where all reusable workflows were converted to composite actions.

Key Changes:

  • Updated workflow job structure to use composite actions instead of reusable workflows
  • Changed from SHA-pinned references to version-tagged references (v1.1.0)
  • Migrated from uses: .../workflows/...yml@SHA to uses: .../actions/...@version format

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/create-release-pr.yml Converted create-release-pr job from reusable workflow to composite action, adding explicit runs-on and steps structure
.github/workflows/update-release-changelog.yml Converted refresh-changelog job from reusable workflow to composite action, adding explicit runs-on and steps structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@Qbandev Qbandev marked this pull request as ready for review November 28, 2025 09:40
pull-requests: write
steps:
- name: Create Release PR
uses: MetaMask/github-tools/.github/actions/create-release-pr@v1.1.0
Copy link

@jluque0101 jluque0101 Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see previous setup referenced to sha instead of v1... , curious to understand if we're good to set versions?

Copy link
Contributor Author

@Qbandev Qbandev Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since v1.0.0 github-tools recommended usage is referencing semantic releases.

@metamaskbot
Copy link
Collaborator

Builds ready [7de3e62]
UI Startup Metrics (1271 ± 104 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12711041151910413501453
load106490113108911221248
domContentLoaded105889512948811141236
domInteractive2716108212288
firstPaint54179131740810441185
backgroundConnect22520428113232249
firstReactRender3419219233464
getState3417140183954
initialActions102112
loadScripts8396911074888911022
setupStore1262841321
numNetworkReqs1257721574
BrowserifyPower User HomeuiStartup21041571349028522912642
load1016888174214410231380
domContentLoaded1002876173214210101362
domInteractive35171832834116
firstPaint57613013943929721298
backgroundConnect261197753121226550
firstReactRender5939105156398
getState204140762109203291
initialActions105112
loadScripts79968415171417841163
setupStore20105882337
numNetworkReqs1606840076198369
WebpackStandard HomeuiStartup819699127388845995
load635564106979649801
domContentLoaded631559106378644796
domInteractive27151292521103
firstPaint22385830153203602
backgroundConnect105728927
firstReactRender2920157183238
getState251350103542
initialActions102111
loadScripts628557105377642788
setupStore1062741217
numNetworkReqs1257621575
WebpackPower User HomeuiStartup16651322243724418972079
load675582114998682926
domContentLoaded665575114399673919
domInteractive36171593232134
firstPaint253102968170230670
backgroundConnect69864114021511
firstReactRender60459796577
getState190136760100181224
initialActions104113
loadScripts662573113497670909
setupStore22651122746
numNetworkReqs1676840775212367
FirefoxBrowserifyStandard HomeuiStartup13161110184816214111625
load106793314039911241328
domContentLoaded106793314029911241328
domInteractive66331833589138
firstPaint------
backgroundConnect43221522844101
firstReactRender24185672537
getState157226251034
initialActions103112
loadScripts104191913859210901266
setupStore14696161056
numNetworkReqs1156515658
BrowserifyPower User HomeuiStartup26241915469558827004260
load1191923268228811711616
domContentLoaded1190922268128811711616
domInteractive12233661126109473
firstPaint------
backgroundConnect118251187188110264
firstReactRender6035132186594
getState25054936199260785
initialActions2127326
loadScripts1128905163716411291534
setupStore18010779199277650
numNetworkReqs98603035487234
WebpackStandard HomeuiStartup14641248203213915491709
load1219105714879312841401
domContentLoaded1219105614879412841401
domInteractive61281393187110
firstPaint------
backgroundConnect47211912747101
firstReactRender26204042836
getState145163241126
initialActions2034322
loadScripts1191104014178512561338
setupStore156197221139
numNetworkReqs1256817764
WebpackPower User HomeuiStartup29752337517369532114454
load14481173284335114412595
domContentLoaded14481173284235014412595
domInteractive1122948711498449
firstPaint------
backgroundConnect152361521206139505
firstReactRender65401992466114
getState364601768349546898
initialActions208123
loadScripts13831147251526213821867
setupStore19261236245233745
numNetworkReqs101572536079245
📊 Page Load Benchmark Results

Current Commit: 7de3e62 | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±36ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 715ms (±35ms) 🟢 | historical mean value: 718ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 75ms (±10ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 36ms 1.00s 1.30s 1.04s 1.30s
domContentLoaded 715ms 35ms 696ms 977ms 728ms 977ms
firstPaint 75ms 10ms 60ms 156ms 84ms 156ms
firstContentfulPaint 75ms 10ms 60ms 156ms 84ms 156ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants