-
Notifications
You must be signed in to change notification settings - Fork 5.4k
ci(INFRA-3081): update github-tools to v1.1.0 for changelog workflows #38365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…ctions Migrate from reusable workflows to composite actions format as per github-tools v1.0.0 breaking change. Updated workflows: - create-release-pr.yml: now uses .github/actions/create-release-pr - update-release-changelog.yml: now uses .github/actions/update-release-changelog This update includes @metamask/auto-changelog v5.2.0 with improved commit deduplication for changelog generation. See: https://github.com/MetaMask/github-tools/releases/tag/v1.1.0
dd02d04 to
2723843
Compare
…gelog Pin github-tools-version to v1.1.0 to prevent defaulting to 'main' branch which could cause unpredictable behavior if main diverges.
Builds ready [a153efa]
UI Startup Metrics (1321 ± 113 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates changelog-related GitHub Actions workflows from reusable workflows to composite actions format, enabling the use of github-tools v1.1.0 which includes improved commit deduplication features from auto-changelog v5.2.0. The migration addresses the breaking change introduced in github-tools v1.0.0 where all reusable workflows were converted to composite actions.
Key Changes:
- Updated workflow job structure to use composite actions instead of reusable workflows
- Changed from SHA-pinned references to version-tagged references (v1.1.0)
- Migrated from
uses: .../workflows/...yml@SHAtouses: .../actions/...@versionformat
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/create-release-pr.yml |
Converted create-release-pr job from reusable workflow to composite action, adding explicit runs-on and steps structure |
.github/workflows/update-release-changelog.yml |
Converted refresh-changelog job from reusable workflow to composite action, adding explicit runs-on and steps structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| pull-requests: write | ||
| steps: | ||
| - name: Create Release PR | ||
| uses: MetaMask/github-tools/.github/actions/create-release-pr@v1.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see previous setup referenced to sha instead of v1... , curious to understand if we're good to set versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since v1.0.0 github-tools recommended usage is referencing semantic releases.
Builds ready [7de3e62]
UI Startup Metrics (1271 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
Migrates the changelog-related GitHub Actions workflows from reusable workflows to composite actions format, as required by github-tools v1.0.0+ breaking change.
Reason for the change:
@36dc168...,@6a04e4d...) pointed to the pre-migration workflow formatChanges made:
create-release-pr.ymluses: .../workflows/create-release-pr.yml@SHAuses: .../actions/create-release-pr@v1.1.0update-release-changelog.ymluses: .../workflows/update-release-changelog.yml@SHAuses: .../actions/update-release-changelog@v1.1.0Benefits of v1.1.0:
@metamask/auto-changelogv5.2.0 with improved commit deduplicationChangelog
CHANGELOG entry: null
Related issues
Fixes: INFRA-3081
See: https://github.com/MetaMask/github-tools/releases/tag/v1.1.0
See: https://github.com/MetaMask/github-tools/releases/tag/v1.0.0 (breaking change)
Manual testing steps
Create Release Pull Requestworkflow with a test versionUpdate Release Changelog PRworkflow runsTesting Evidence
✅ Tested in fork repository: consensys-test/metamask-extension-test
update-release-changelogworkflowTest Results:
MetaMask/github-tools@v1.1.0release-branch,platform,github-tools-version: v1.1.0)Screenshots/Recordings
N/A - CI/CD workflow migration
Before
N/A
After
N/A
Pre-merge author checklist
Pre-merge reviewer checklist