fix: test actions missing awaits #38381
Merged
+17
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✨ Files requiring CODEOWNER review ✨🧪 @MetaMask/qa (2 files, +16 -7)
|
seaona
added
e2e-maintenance
flaky tests
no-changelog
Collaborator
Builds ready [a3e5c27]
UI Startup Metrics (1222 ± 104 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
seaona
commented
Nov 28, 2025
| async waitForHexDataCleared(): Promise<string> { | ||
| console.log('Getting value from hex input'); | ||
| const hexInputElement = await this.driver.waitForSelector(this.hexInput); | ||
| this.driver.waitForNonEmptyElement(hexInputElement); |
Member
Author
There was a problem hiding this comment.
after adding the missing awaits, this has surfaced an issue with this method. This makes the test fail, as in the spec, we call this function when we are trying to assert the element is empty:
// Make sure hex data is cleared after switching assets
Given the hex data is empty in that case, the waitForNonEmptyElement never happens and the spec fails
The way this function is implemented is also a bit dangerous for introducing race conditions (getting an element and then the value, and making an assertion against that).
So I've changed this to wait for a specific value (Empty), given that's the only case we are using this.
If in the future we need to assert against a value we'll need to create a new function to support that - but not needed now.
Collaborator
Builds ready [c58a864]
UI Startup Metrics (1336 ± 144 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Unik0rnMaggie
approved these changes
Nov 28, 2025
jvbriones
approved these changes
Nov 28, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.13.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some async methods were missing the
awaitkey. This has been added and has surfaced an issue with a method, which has also been fixed.Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Adds awaited click actions in dialog/send pages and replaces hex data assertion with a wait-based helper, updating tests accordingly.
test/e2e/page-objects/pages/dialog/confirm-alert.ts: Addawaitto alert modal interactions (rejectFromAlertModal,confirmFromAlertModal,acknowledgeAlert).test/e2e/page-objects/pages/send/send-token-page.ts:getHexInputValuewithwaitForHexDataCleared, which waits until the hex input is empty usingwaitUntil.test/e2e/tests/transaction/change-assets.spec.ts:waitForHexDataCleared()instead.Written by Cursor Bugbot for commit c58a864. This will update automatically on new commits. Configure here.