release(runway): cherry-pick feat: cp-13.12.0 confirmations for sidepanel #38394
+100
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Enables the confirmation handler to listen from pages other than the home page. There's a list of exempted routes including the confirmation routes. Depends on #38361 <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/38375?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: feat: confirmations for sidepanel ## **Related issues** Fixes: ## **Manual testing steps** 1. Switch to sidepanel 2. Test requests and approvals ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Enable confirmation navigation from any route (incl. sidepanel), add side panel manifest/config, and centralize network menu modal with a close action. > > - **Confirmations & Navigation**: > - Run confirmation redirection from any route via `ConfirmationHandler` with an exempted-routes list; closes open modals before navigating. > - Remove reliance on home/default route checks. > - **Modals Refactor**: > - Add `useModalState` hook and `CLOSE_NETWORK_MENU` action; update reducer to support explicit close. > - Introduce `Modals` aggregator to render `NetworkListMenu`; integrate into `routes.component` and remove inline menu handling. > - Export selector `selectIsNetworkMenuOpen`. > - **Sidepanel Enablement**: > - Add `"sidePanel"` permission and Chrome `side_panel.default_path` in `manifest`. > - Set `IS_SIDEPANEL: true` for main build. > - **Cleanup**: > - Remove unused sidepanel/env and swaps-related props from `home.container`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit c08536b. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/core-extension-ux (1 files, +0 -12)
|
Collaborator
Builds ready [a91ea96]
UI Startup Metrics (1276 ± 116 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
gauthierpetetin
approved these changes
Nov 28, 2025
metamaskbot
added
the
release-13.12.0
Collaborator
|
No release label on PR. Adding release label release-13.12.0 on PR, as PR was cherry-picked in branch 13.12.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
](https://codespaces.new/MetaMask/metamask-extension/pull/38375?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables the confirmation handler to listen from pages other than the
home page.
There's a list of exempted routes including the confirmation routes.
Depends on #38361
Changelog
CHANGELOG entry: feat: confirmations for sidepanel
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Enables confirmation routing across routes (incl. sidepanel), centralizes modal handling with a network menu close action, and updates manifests/builds for side panel support.
ConfirmationHandlernow runs outsideDEFAULT_ROUTE, adds exempt routes, and closes modals before navigating.useModalStatehook andModalscontainer to renderNetworkListMenu; routes integrateModalsand remove inline network menu handling.CLOSE_NETWORK_MENUaction/reducer; exportcloseNetworkMenu; add selectorselectIsNetworkMenuOpen.home.container."sidePanel"permission and Chromeside_panel.default_path.IS_SIDEPANEL: truefor main build.Written by Cursor Bugbot for commit a91ea96. This will update automatically on new commits. Configure here.
3c42ac3