test: fix flaky test `Port Stream Chunking can load the wallet UI with a huge background state (~128MB)` #38395

seaona · 2025-11-28T11:36:52Z

Description

Controllers take longer than usual to load if we use a wallet with a big state, causing the spec to fail as controllers are not loaded within 10 seconds (the css class which indicates that).
This increases the timeout for this specific test.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Check ci -- note the spec was run multiple times due to the e2e quality gate, and it passed 100% of times

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2025-11-28T12:10:00Z

Builds ready [f341474]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1211 ± 96 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1211	997	1535	96	1287	1374
			load	1017	863	1197	89	1084	1181
			domContentLoaded	1011	857	1189	87	1076	1172
			domInteractive	26	15	95	20	21	89
			firstPaint	525	91	1244	395	996	1150
			backgroundConnect	211	194	262	10	216	230
			firstReactRender	31	20	59	10	37	53
			getState	35	15	118	19	41	99
			initialActions	1	0	5	1	1	2
			loadScripts	806	659	972	85	868	965
			setupStore	11	6	28	4	12	21
			numNetworkReqs	12	5	78	20	5	73
	Browserify	Power User Home	uiStartup	2106	1757	2718	248	2306	2670
			load	1030	898	1503	133	1040	1356
			domContentLoaded	1016	890	1496	133	1021	1348
			domInteractive	37	17	228	34	33	127
			firstPaint	603	103	1461	397	984	1264
			backgroundConnect	254	204	621	91	233	531
			firstReactRender	64	40	126	18	71	102
			getState	184	130	277	33	207	252
			initialActions	1	0	10	1	1	4
			loadScripts	805	681	1293	133	812	1138
			setupStore	22	11	64	10	25	41
			numNetworkReqs	103	66	283	54	98	269
	Webpack	Standard Home	uiStartup	857	719	1172	89	901	1049
			load	657	585	898	71	683	827
			domContentLoaded	652	579	890	71	676	819
			domInteractive	27	16	106	23	22	95
			firstPaint	231	81	895	173	226	652
			backgroundConnect	11	6	73	8	11	26
			firstReactRender	28	20	60	7	33	40
			getState	29	13	197	20	36	47
			initialActions	1	0	7	1	1	2
			loadScripts	649	577	881	69	674	809
			setupStore	12	7	46	5	14	21
			numNetworkReqs	12	5	77	20	5	73
	Webpack	Power User Home	uiStartup	1695	1287	2674	276	1971	2212
			load	698	595	1237	110	695	964
			domContentLoaded	688	591	1221	110	681	958
			domInteractive	38	19	205	32	35	123
			firstPaint	304	116	1233	221	292	732
			backgroundConnect	66	7	669	158	19	580
			firstReactRender	62	47	107	9	68	75
			getState	192	133	739	77	190	221
			initialActions	1	0	2	0	1	2
			loadScripts	685	589	1211	108	679	949
			setupStore	22	10	56	12	25	51
			numNetworkReqs	175	64	430	84	215	419
Firefox	Browserify	Standard Home	uiStartup	1308	1075	1791	155	1377	1640
			load	1082	923	1523	114	1143	1348
			domContentLoaded	1082	923	1523	114	1143	1348
			domInteractive	64	32	163	34	86	136
			firstPaint	-	-	-	-	-	-
			backgroundConnect	45	22	173	28	59	104
			firstReactRender	23	18	50	6	24	42
			getState	12	7	121	14	10	22
			initialActions	1	0	2	1	2	2
			loadScripts	1054	906	1463	105	1099	1259
			setupStore	12	5	221	21	10	21
			numNetworkReqs	11	5	66	16	6	63
	Browserify	Power User Home	uiStartup	2597	2025	4210	357	2736	3329
			load	1190	979	1663	150	1189	1578
			domContentLoaded	1190	979	1663	150	1189	1578
			domInteractive	129	37	571	120	118	508
			firstPaint	-	-	-	-	-	-
			backgroundConnect	109	30	463	65	125	235
			firstReactRender	61	42	132	17	65	105
			getState	231	68	795	161	233	676
			initialActions	3	1	25	3	3	8
			loadScripts	1158	956	1633	146	1159	1535
			setupStore	175	12	769	201	207	685
			numNetworkReqs	101	61	314	63	80	244
	Webpack	Standard Home	uiStartup	1542	1363	1989	125	1618	1768
			load	1271	1127	1494	78	1315	1426
			domContentLoaded	1271	1126	1493	78	1315	1426
			domInteractive	75	29	150	27	93	120
			firstPaint	-	-	-	-	-	-
			backgroundConnect	47	19	187	29	48	113
			firstReactRender	29	23	82	9	30	41
			getState	18	7	135	25	14	114
			initialActions	1	0	3	1	2	2
			loadScripts	1244	1112	1425	70	1293	1382
			setupStore	15	6	122	15	14	41
			numNetworkReqs	12	5	67	17	7	63
	Webpack	Power User Home	uiStartup	2964	2265	5095	688	2913	4713
			load	1472	1156	3031	427	1426	2746
			domContentLoaded	1471	1155	3031	428	1425	2746
			domInteractive	113	28	590	118	102	434
			firstPaint	-	-	-	-	-	-
			backgroundConnect	184	28	1338	281	147	1150
			firstReactRender	66	39	282	37	64	144
			getState	324	66	1255	252	520	793
			initialActions	2	0	7	1	2	3
			loadScripts	1360	1132	2719	228	1406	1785
			setupStore	164	7	759	186	257	598
			numNetworkReqs	100	58	317	60	80	238

📊 Page Load Benchmark Results

Current Commit: f341474 | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.02s (±40ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
domContentLoaded-> current mean value: 710ms (±36ms) 🟢 | historical mean value: 724ms ⬇️ (historical data)
firstContentfulPaint-> current mean value: 75ms (±11ms) 🟢 | historical mean value: 78ms ⬇️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.02s	40ms	996ms	1.30s	1.07s	1.30s
domContentLoaded	710ms	36ms	689ms	976ms	740ms	976ms
firstPaint	75ms	11ms	56ms	164ms	84ms	164ms
firstContentfulPaint	75ms	11ms	56ms	164ms	84ms	164ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 768 Bytes (0.02%)
ui: 2.16 KiB (0.03%)
common: 7.39 KiB (0.08%)

chloeYue

LGTM

metamaskbot · 2025-11-28T12:53:45Z

Builds ready [d20aea0]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18
- content-script: 0
- offscreen: 0

UI Startup Metrics (1226 ± 96 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1226	1041	1430	96	1298	1391
			load	1025	865	1214	87	1081	1189
			domContentLoaded	1020	858	1209	86	1077	1177
			domInteractive	25	15	96	20	21	86
			firstPaint	460	95	1212	388	985	1174
			backgroundConnect	218	198	247	10	224	234
			firstReactRender	33	20	133	15	37	58
			getState	39	14	127	20	45	101
			initialActions	1	0	5	1	1	2
			loadScripts	807	650	983	83	849	968
			setupStore	11	6	26	4	12	21
			numNetworkReqs	12	5	77	20	5	73
	Browserify	Power User Home	uiStartup	2115	1735	3313	284	2314	2640
			load	1032	896	1748	148	1029	1417
			domContentLoaded	1018	889	1739	148	1011	1410
			domInteractive	36	18	151	30	34	130
			firstPaint	542	88	1757	402	965	1306
			backgroundConnect	261	209	661	106	230	543
			firstReactRender	59	43	100	14	63	95
			getState	187	134	337	33	204	255
			initialActions	1	0	7	1	1	2
			loadScripts	808	688	1520	147	804	1208
			setupStore	21	10	72	9	24	32
			numNetworkReqs	157	67	417	77	205	325
	Webpack	Standard Home	uiStartup	869	731	1182	97	915	1068
			load	676	592	983	88	697	878
			domContentLoaded	671	586	975	87	694	873
			domInteractive	28	17	122	24	23	100
			firstPaint	262	82	982	196	240	680
			backgroundConnect	11	6	54	7	11	27
			firstReactRender	28	21	59	7	32	42
			getState	27	14	55	10	35	44
			initialActions	1	0	3	1	1	2
			loadScripts	668	584	966	86	692	864
			setupStore	11	7	25	4	14	21
			numNetworkReqs	12	5	77	20	5	73
	Webpack	Power User Home	uiStartup	1634	1264	2215	260	1904	2123
			load	667	576	958	90	682	908
			domContentLoaded	657	570	951	91	669	902
			domInteractive	37	18	168	34	34	136
			firstPaint	293	93	960	211	290	770
			backgroundConnect	73	7	615	154	19	559
			firstReactRender	62	44	113	12	65	85
			getState	165	87	225	20	174	209
			initialActions	1	0	8	1	1	2
			loadScripts	654	568	942	89	666	894
			setupStore	24	7	65	15	32	55
			numNetworkReqs	126	68	374	66	133	320
Firefox	Browserify	Standard Home	uiStartup	1343	1091	1911	147	1438	1570
			load	1095	947	1352	90	1143	1272
			domContentLoaded	1094	946	1351	90	1142	1272
			domInteractive	65	31	223	35	86	125
			firstPaint	-	-	-	-	-	-
			backgroundConnect	48	23	354	42	44	100
			firstReactRender	25	19	53	8	26	44
			getState	15	7	233	27	12	33
			initialActions	1	0	3	1	2	2
			loadScripts	1066	932	1326	82	1113	1227
			setupStore	14	5	201	27	11	31
			numNetworkReqs	11	5	66	14	6	53
	Browserify	Power User Home	uiStartup	2692	2018	5079	593	2722	4068
			load	1216	963	2998	328	1181	1750
			domContentLoaded	1216	963	2997	328	1181	1750
			domInteractive	122	33	678	128	103	486
			firstPaint	-	-	-	-	-	-
			backgroundConnect	134	24	1103	165	123	434
			firstReactRender	61	35	240	26	61	97
			getState	313	59	941	227	453	838
			initialActions	2	1	46	5	2	3
			loadScripts	1172	932	2802	297	1139	1620
			setupStore	148	8	759	186	151	612
			numNetworkReqs	102	59	313	63	80	242
	Webpack	Standard Home	uiStartup	1527	1259	2009	149	1635	1800
			load	1257	1092	1551	105	1346	1425
			domContentLoaded	1257	1092	1550	105	1346	1424
			domInteractive	67	23	234	38	90	127
			firstPaint	-	-	-	-	-	-
			backgroundConnect	52	18	315	41	52	113
			firstReactRender	25	20	81	7	26	35
			getState	16	7	153	24	13	81
			initialActions	1	0	2	1	2	2
			loadScripts	1226	1069	1521	97	1309	1378
			setupStore	17	5	243	32	11	60
			numNetworkReqs	11	5	68	16	7	60
	Webpack	Power User Home	uiStartup	2945	2113	4975	662	2967	4566
			load	1475	1169	3001	416	1469	2740
			domContentLoaded	1475	1169	3000	416	1468	2740
			domInteractive	111	30	528	110	100	395
			firstPaint	-	-	-	-	-	-
			backgroundConnect	159	31	1436	232	134	461
			firstReactRender	70	41	382	43	67	145
			getState	283	68	930	209	385	734
			initialActions	2	0	33	3	2	3
			loadScripts	1403	1144	2771	330	1414	2510
			setupStore	162	5	814	210	207	703
			numNetworkReqs	100	58	250	58	83	243

📊 Page Load Benchmark Results

Current Commit: d20aea0 | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

pageLoadTime-> current mean value: 1.05s (±43ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
domContentLoaded-> current mean value: 731ms (±42ms) 🟢 | historical mean value: 728ms ⬆️ (historical data)
firstContentfulPaint-> current mean value: 79ms (±12ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.05s	43ms	1.02s	1.40s	1.07s	1.40s
domContentLoaded	731ms	42ms	703ms	1.07s	751ms	1.07s
firstPaint	79ms	12ms	60ms	184ms	92ms	184ms
firstContentfulPaint	79ms	12ms	60ms	184ms	92ms	184ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 768 Bytes (0.02%)
ui: 2.25 KiB (0.03%)
common: 7.4 KiB (0.08%)

test

f341474

metamaskbot added the team-qa QA team label Nov 28, 2025

github-actions bot added the size-XS label Nov 28, 2025

seaona changed the title ~~test: debug port~~ test: fix flaky test Port Stream Chunking can load the wallet UI with a huge background state (~128MB) Nov 28, 2025

seaona self-assigned this Nov 28, 2025

seaona added flaky tests no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Nov 28, 2025

revert test key to run quality gate and refactor fix

815e9d4

github-actions bot added size-S and removed size-XS labels Nov 28, 2025

lint

d20aea0

seaona marked this pull request as ready for review November 28, 2025 12:20

FrederikBolding approved these changes Nov 28, 2025

View reviewed changes

chloeYue approved these changes Nov 28, 2025

View reviewed changes

seaona added this pull request to the merge queue Nov 28, 2025

Merged via the queue into main with commit f855a5e Nov 28, 2025
197 of 198 checks passed

seaona deleted the flaky-controllers-heavy-data branch November 28, 2025 13:53

github-actions bot locked and limited conversation to collaborators Nov 28, 2025

metamaskbot added the release-13.13.0 Issue or pull request that will be included in release 13.13.0 label Nov 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: fix flaky test `Port Stream Chunking can load the wallet UI with a huge background state (~128MB)` #38395

test: fix flaky test `Port Stream Chunking can load the wallet UI with a huge background state (~128MB)` #38395

seaona commented Nov 28, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Nov 28, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

chloeYue left a comment

Uh oh!

metamaskbot commented Nov 28, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

test: fix flaky test Port Stream Chunking can load the wallet UI with a huge background state (~128MB) #38395

test: fix flaky test Port Stream Chunking can load the wallet UI with a huge background state (~128MB) #38395

Conversation

seaona commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Nov 28, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

chloeYue left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Nov 28, 2025

📄 Localhost MetaMask Test Dapp

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

test: fix flaky test `Port Stream Chunking can load the wallet UI with a huge background state (~128MB)` #38395

test: fix flaky test `Port Stream Chunking can load the wallet UI with a huge background state (~128MB)` #38395

seaona commented Nov 28, 2025 •

edited

Loading