Add metamask_watchAsset #4606

danfinlay · 2018-06-18T22:51:43Z

Adds the method metamask_watchAsset, a vendor-prefixed version of wallet_watchAsset per EIP 747.

To Do:

Refine & finalize the EIP specification.
Fix rpc-engine crash preventing the confirmation from working correctly.
Add parameter for specifying token icon (maybe as a base64 string w/ a max length)

Sample Usage

web3.currentProvider.sendAsync({
  method: 'metamask_watchAsset',
  params: {
    "type":"ERC20",
    "options":{
      "address":"0x2e8c6bbe8e3aa934ee5a851b2cdff52412d61b86",
      "symbol":"FOX",
      "decimals":18,
      "image":'https://pbs.twimg.com/profile_images/802481220340908032/M_vde_oi_400x400.jpg'
    },
  },
  id: 20,
}, console.log)

estebanmino · 2018-08-03T23:30:17Z

Right now this PR is working as follow

@cjeria @danfinlay any thoughts on how it should be the cancellation of this suggestion?

estebanmino · 2018-08-07T00:28:03Z

A new component was created to confirm the suggested tokens as you can see on the video. I think that could be a better approach for it. Thoughts?

Now we have the possibility to developers that want to use this feature to send a personal message through the method to the user, giving more information about this suggested token (?).

@danfinlay @cjeria

metamaskbot · 2018-08-07T22:16:02Z

Builds ready [15ea8c0]: mascara, chrome, firefox, edge, opera

danfinlay · 2018-08-13T16:48:43Z

Okay, three thoughts:

I'd like to get @cjeria to review the UX here. I think this might be worth some dedicated UI, since "back" and selecting other tokens is not really in the spirit of the feature.
I'd like us to tuck the method under some kind of beta flag until we have an EIP and want to formalize: Maybe metamask_watchToken? Is that crazy?
I'd like the method to support a token image also. Not sure whether it should be a bytes64 encoded jpeg, or a link to a hosted image or what. That might be a good question for an ethereum-magicians post. I'm happy to help draft that.

estebanmino · 2018-08-13T17:56:21Z

Following your comments @danfinlay

There are new components for this feature, in order to avoid the Back button there is a Cancel button that closes the notification. Working on new and old UI.

Sounds good, not crazy for me at least.
How do we continue with this?

brunobar79

LGTM! just a few strings that should be moved to the localization files and a potential safe check.

brunobar79 · 2018-08-27T19:07:25Z

app/scripts/controllers/preferences.js

@@ -247,7 +306,8 @@ class PreferencesController {
    } else {
      tokens.push(newEntry)
    }
-    this._updateAccountTokens(tokens)
+    assetImages[address] = image


Not sure if it's really needed but maybe use toChecksumAddress or normalizeAddress to make sure it will always find the right key (assuming that assetImages keys are already checksummed)

Yes, in line 295 the normalization happens, so for each token added it will have as key the correct normalized address.

brunobar79 · 2018-08-27T19:12:47Z

old-ui/app/add-suggested-token.js

+
+  const ownAddress = identitiesList.includes(standardAddress)
+  if (ownAddress) {
+    msg = 'Personal address detected. Input the token contract address.'


I agree with all these comments about messages.json file, but the original old ui (old-ui/app/add-tokens.js) all names are in this way and are not used to do translations, so I assumed that this wasn't necessary. Let me know what you think.

Disregard all the previous comments about localization. Didn't realize it was old-ui

brunobar79 · 2018-08-27T19:13:37Z

test/unit/app/controllers/preferences-controller-test.js

+      sandbox.restore()
+    })
+
+    it('should do anything if method not corresponds', async function () {


shouldn't ?

wojaskrk@gmail.com

bitpshr

This looks great. There are a few strings that can be internationalized, but nothing show-stopping. Excited to see this feature in the wild.

One question: are we standardizing on the metamask_ custom RPC method prefix? Should we version this as well in case new versions of the proposal arise?

bitpshr · 2018-08-27T21:14:21Z

app/scripts/controllers/preferences.js

@@ -1,5 +1,6 @@
 const ObservableStore = require('obs-store')
 const normalizeAddress = require('eth-sig-util').normalize
+const isValidAddress = require('ethereumjs-util').isValidAddress


Nit: You can save one level of indirection by doing const { isValidAddress } = require('ethereumjs-util');

metamaskbot · 2018-08-28T01:24:03Z

Builds ready [3106374]: mascara, chrome, firefox, edge, opera

estebanmino · 2018-08-28T01:25:56Z

Thanks for reviewing this.
@bitpshr the idea of that prefix is to have the first version of this before watchAsset is standardized on EM, we want to test and find room to improve it.
Waiting for @brunobar79 comments to merge.

brunobar79

Looks good! Ping me after resolving conflicts and I'll merge

ghost · 2021-04-24T08:59:41Z

Why is there a Character Limit for the symbol? e.g. Tokens with a character length of 8 can be imported into Metamask via the address but not with this method.

github-actions · 2021-04-24T08:59:54Z

CLA Signature Action:

Thank you for your submission, we really appreciate it. We ask that you all read and sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just by adding a comment to this pull request with this exact sentence:

I have read the CLA Document and I hereby sign the CLA

By commenting with the above message you are agreeing to the terms of the CLA. Your account will be recorded as agreeing to our CLA so you don't need to sign it again for future contributions to this repository.

1 out of 2 committers have signed the CLA.
✅ @danfinlay
❌ @estebanmino

df257 · 2021-11-24T11:19:05Z

I want add two token together, how to do it?
like this:

hiroshi-yamamoto-dublr · 2022-07-21T01:45:19Z

Trying to add the same token twice gives the following error:

This warning should not be given if the token was already added to the wallet with the same chainId and token address (in fact the MetaMask window should probably not pop up at all in that case). This way the caller doesn't have to first call the MetaMask API to see if the token is already in the wallet (if that is even possible?) before calling the EIP747 API.

Winrargivemebot · 2022-10-30T02:56:07Z

ethereum.request({
method: 'wallet_watchAsset',
params: {
type: 'ERC20',
options: {
address: '0x02bfed0e1b1186e80ea3c74b43b22ffde8f8238a',
symbol: '$PEN',
decimals: 18,
image: 'https://i.ibb.co/pfVjJCV/PENGUIN.png',
},
},
});
.then((success) => {
if (success) {
console.log('FOO successfully added to wallet!')
} else {
throw new Error('Something went wrong.')
}
})
.catch(console.error)

WojasKrk · 2023-06-27T03:49:12Z

Builds ready [56bed3f]: mascara, chrome, firefox, edge, opera

danfinlay added 5 commits June 18, 2018 15:07

Begin adding eth_watchToken

5d7c281

Begin letting UI show suggested tokens

f14ed32

Get popup appearing when suggesting new token

5e4f3e4

Linted

d26ce80

Improved rpc-engine usage

0481335

danfinlay added the DO-NOT-MERGE Pull requests that should not be merged label Jun 18, 2018

estebanmino added 4 commits August 3, 2018 14:56

merge develop

21a61f2

rpc-engine not crashing when eth_watchToken

081884b

popup initializing with suggested tokens

12dd7a7

eth_watchToken working

9ac9f53

danfinlay requested review from alextsg, danjm and whymarrh as code owners August 3, 2018 23:24

estebanmino added 4 commits August 6, 2018 18:28

add suggested token params validation

78ad3c3

fix duplicated action

88933f3

new confirm add suggested token component

af35b41

clean confirm add token component

a57f56f

estebanmino added 4 commits August 7, 2018 14:16

wip watch token old ui

1f8a808

watch token on old ui

00d1f6f

Merge branch 'develop' into WatchTokenFeature

3f57d5f

fix merge

15ea8c0

estebanmino added 2 commits August 7, 2018 19:12

refactor unused code

33357e3

show token address summary on old ui

c245405

estebanmino added 2 commits August 14, 2018 13:58

update method to metamask_watchToken

8f5b80a

add support for images base64 and urls on new ui

a4c3f6b

danfinlay removed the DO-NOT-MERGE Pull requests that should not be merged label Aug 23, 2018

danfinlay changed the title ~~[DO NOT MERGE] - Begin adding eth_watchToken~~ Add wallet_watchAsset Aug 23, 2018

danfinlay changed the title ~~Add wallet_watchAsset~~ Add metamask_watchAsset Aug 23, 2018

estebanmino added 3 commits August 23, 2018 15:54

typo watchAsset imageUrl to image

b59a1e9

delete web3.metamassk.watchAsset

053e262

add watchAsset CHANGELOG

8af45d5

brunobar79 reviewed Aug 27, 2018

View reviewed changes

bitpshr previously approved these changes Aug 27, 2018

View reviewed changes

watchAsset small changes

3106374

estebanmino dismissed bitpshr’s stale review via 3106374 August 28, 2018 01:10

brunobar79 previously approved these changes Aug 28, 2018

View reviewed changes

estebanmino dismissed brunobar79’s stale review via 1c801b5 August 28, 2018 17:38

estebanmino force-pushed the WatchTokenFeature branch from 1c801b5 to 3106374 Compare August 28, 2018 17:41

fix conflicts

e743f44

brunobar79 approved these changes Aug 28, 2018

View reviewed changes

brunobar79 merged commit 4560df6 into develop Aug 28, 2018

whymarrh deleted the WatchTokenFeature branch September 5, 2018 19:54

bdresser mentioned this pull request Sep 12, 2018

Add eth_watchToken method to provider. #4112

Closed

tmashuang mentioned this pull request Sep 17, 2018

Version 4.10.0 #5281

Merged

oberstet mentioned this pull request Dec 5, 2018

automatically add XBR token in dapps wamp-proto/wamp-xbr#15

Closed

oberstet mentioned this pull request Oct 13, 2019

Fix EIP712 chain ID handling wamp-proto/wamp-xbr#51

Closed

abbassabb mentioned this pull request Jul 7, 2022

Abbas Sabah Al-Obaidi desktop/desktop#14925

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add metamask_watchAsset #4606

Add metamask_watchAsset #4606

danfinlay commented Jun 18, 2018 •

edited

Loading

estebanmino commented Aug 3, 2018 •

edited

Loading

estebanmino commented Aug 7, 2018

metamaskbot commented Aug 7, 2018

danfinlay commented Aug 13, 2018

estebanmino commented Aug 13, 2018

brunobar79 left a comment

brunobar79 Aug 27, 2018

estebanmino Aug 28, 2018

brunobar79 Aug 27, 2018

estebanmino Aug 28, 2018

brunobar79 Aug 28, 2018 •

edited

Loading

brunobar79 Aug 27, 2018

floreschristian Jul 5, 2022

WojasKrk Jun 27, 2023

bitpshr left a comment

bitpshr Aug 27, 2018

metamaskbot commented Aug 28, 2018

estebanmino commented Aug 28, 2018

brunobar79 left a comment

ghost commented Apr 24, 2021

github-actions bot commented Apr 24, 2021 •

edited

Loading

df257 commented Nov 24, 2021

hiroshi-yamamoto-dublr commented Jul 21, 2022 •

edited

Loading

Winrargivemebot commented Oct 30, 2022

WojasKrk commented Jun 27, 2023

Add metamask_watchAsset #4606

Add metamask_watchAsset #4606

Conversation

danfinlay commented Jun 18, 2018 • edited Loading

Sample Usage

estebanmino commented Aug 3, 2018 • edited Loading

estebanmino commented Aug 7, 2018

metamaskbot commented Aug 7, 2018

danfinlay commented Aug 13, 2018

estebanmino commented Aug 13, 2018

brunobar79 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brunobar79 Aug 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bitpshr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

metamaskbot commented Aug 28, 2018

estebanmino commented Aug 28, 2018

brunobar79 left a comment

Choose a reason for hiding this comment

ghost commented Apr 24, 2021

github-actions bot commented Apr 24, 2021 • edited Loading

df257 commented Nov 24, 2021

hiroshi-yamamoto-dublr commented Jul 21, 2022 • edited Loading

Winrargivemebot commented Oct 30, 2022

WojasKrk commented Jun 27, 2023

danfinlay commented Jun 18, 2018 •

edited

Loading

estebanmino commented Aug 3, 2018 •

edited

Loading

brunobar79 Aug 28, 2018 •

edited

Loading

github-actions bot commented Apr 24, 2021 •

edited

Loading

hiroshi-yamamoto-dublr commented Jul 21, 2022 •

edited

Loading