Add hex data input to send screen #4814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
commented
Jul 18, 2018
| shouldComponentUpdate (nextProps, nextState, nextContext) { | ||
| const {data, inError} = this.props | ||
| const {nextData, nextInError} = nextProps | ||
| return data !== nextData || inError !== nextInError |
There was a problem hiding this comment.
This shouldComponentUpdate isn't needed because these are primitive values
|
|
||
| return ( | ||
| <SendRowWrapper | ||
| label={`${this.context.t('hexData')}:`} |
There was a problem hiding this comment.
Destructure this.context
| txParams: Object.assign( | ||
| unapprovedTx.txParams, | ||
| addHexPrefixToObjectValues({data}), | ||
| addHexPrefixToObjectValues({data: unapprovedTx.txParams.data}), |
There was a problem hiding this comment.
This isn't particularly clear and needs explanation—why is this needed?
| onInput = (event) => { | ||
| const {updateSendHexData} = this.props | ||
| event.target.value = event.target.value.replace(/\n/g, '') | ||
| updateSendHexData(event.target.value) |
There was a problem hiding this comment.
If value is an empty string we should be removing the data
alextsg
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3430
This PR adds the ability to edit the hex data for a tx when sending it.