Show error while allowing confirmation of tx where simulation fails #5000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypollack
approved these changes
Aug 9, 2018
whymarrh
approved these changes
Aug 9, 2018
| @@ -124,7 +124,7 @@ export default class ConfirmTransactionBase extends Component { | |||
|
|
|||
| if (simulationFails) { | |||
| return { | |||
| valid: false, | |||
| valid: true, | |||
There was a problem hiding this comment.
This makes sense, good catch
| @@ -1,3 +1,3 @@ | |||
| export const INSUFFICIENT_FUNDS_ERROR_KEY = 'insufficientFunds' | |||
| export const GAS_LIMIT_TOO_LOW_ERROR_KEY = 'gasLimitTooLow' | |||
| export const TRANSACTION_ERROR = 'transactionError' | |||
| export const TRANSACTION_ERROR_KEY = 'transactionError' | |||
There was a problem hiding this comment.
We should expand our ESLint rules to include something like import/no-unresolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4980
Before:
After:
