Add Transaction Details to the Transaction List view #5182
Conversation
alextsg
commented
Aug 31, 2018
alextsg
commented
alextsg
force-pushed
the
tx-activity
branch
2 times, most recently
from
7fdc2a3 to
debffb0
Compare
| @@ -0,0 +1,26 @@ | |||
| import React from 'react' | |||
There was a problem hiding this comment.
I just noticed that we have been using different naming conventions for test files. I've been doing name-component.test.js for the test file corresponding to name.component.js... I think I like yours better.
| numberOfDecimals: 6, | ||
| }) | ||
| export function getEthConversionFromWeiHex ({ value, conversionRate, numberOfDecimals = 6 }) { | ||
| const denominations = [ETH, GWEI, WEI] |
There was a problem hiding this comment.
If I am reading this right, it is to ensure that the activity log shows the value associated with each activity in the largest possible denomination. Is that correct?
There was a problem hiding this comment.
Right, or another way of putting it, if the value is too small for a particular denomination (and the result is 0 ETH, for example), it goes to a lower denomination and so on.
There was a problem hiding this comment.
I think for the "transaction created" row, the value should always be shown in ETH. When the user creates the transaction, they will be creating it in ETH, so showing in GWEI or WEI is confusing.
ui/app/helpers/transactions.util.js
Outdated
| @@ -103,3 +105,13 @@ export async function isSmartContractAddress (address) { | |||
| const code = await global.eth.getCode(address) | |||
| return code && code !== '0x' | |||
| } | |||
|
|
|||
| export function addHex (...args) { | |||
There was a problem hiding this comment.
Maybe call this sumHexes so that it is clear it can accept any number of arguments?
| } | ||
|
|
||
| default: { | ||
| events.push(eventCreator(value, timestamp)) |
There was a problem hiding this comment.
events.push(eventCreator(value, timestamp))
The eventCreator(value, timestamp) call needs some default parameter for the eventKey
|
Styling issue in contract deployment 'sender-to-recipient'
|
|
I wonder if contract deployments should have a different creation message than 'Transaction created with a value of 0 WEI.'? I'm not positive about this, but I think it is worth considering. |
|
Token transactions should probably show token value for "Amount" in transaction breakdown and for the 'Transaction created' row in the activity log.
|
|
The recipient address in the 'sender-to-recipient' for token transactions should probably be the address of the account to which the tokens were transferred, instead of the contract transaction. |
|
The previous two comments also apply to Approvals. |
…hin app to Button components
…ivity Log initial ETH value. Add timestamps to Activity Log events
alextsg
force-pushed
the
tx-activity
branch
from
3df31db to
f1a309e
Compare
