Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct loading message when connecting to Kovan #5189

Merged
merged 6 commits into from
Sep 6, 2018
Merged

Use correct loading message when connecting to Kovan #5189

merged 6 commits into from
Sep 6, 2018

Conversation

eugeneiiim
Copy link
Contributor

@eugeneiiim eugeneiiim commented Sep 3, 2018 •
edited
Loading

Fixes #5190

danjm
danjm previously approved these changes Sep 5, 2018
View reviewed changes
@danjm
Copy link
Contributor

danjm commented Sep 5, 2018

Thanks @eugeneiiim

There is a merge conflict in CHANGELOG.md. Can you resolve it? Then we can merge,

@eugeneiiim
Copy link
Contributor Author

Resolved the conflict.

@whymarrh
Copy link
Contributor

whymarrh commented Sep 5, 2018

@eugeneiiim mind updating this PR with the latest develop? #5206 was just merged and should fix the failing checks.

@whymarrh whymarrh merged commit d273329 into MetaMask:develop Sep 6, 2018
@whymarrh
Copy link
Contributor

whymarrh commented Sep 6, 2018

Thanks @eugeneiiim!

@tmashuang tmashuang mentioned this pull request Sep 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm danjm left review comments

@alextsg alextsg Awaiting requested review from alextsg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eugeneiiim @danjm @whymarrh