Fix updating of pending transactions #5431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transaction statuses were not being properly updated when: - MetaMask was unlocked - The network was changed This PR fixes both of those. Fixes #5174
whymarrh
suggested changes
Oct 5, 2018
|
@whymarrh the trash icon was to remove the file entirely. I made a new commit checking out the |
whymarrh
approved these changes
Oct 5, 2018
whymarrh
added a commit
to whymarrh/metamask-extension
that referenced
this pull request
Apr 28, 2020
whymarrh
added a commit
that referenced
this pull request
Apr 29, 2020
Gudahtt
pushed a commit
that referenced
this pull request
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction statuses were not being properly updated when:
This PR fixes both of those. Fixes #5174
This meant if you had a pending tx that was mined while either locked or on a different network, metamask would seemingly never update that transaction's status.