100% French locale, Reordering of English locale, Fixes #5457: issue with verify-locale-strings.js #5470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
suggested changes
Oct 9, 2018
|
I tried to leave comments for each of the lines that will be updated to make sure we catch everything. I probably missed some instances of the messages not being in sentence case though if you want to give it a once-over. |
|
Fixes pushed. Thanks a lot @whymarrh |
whymarrh
approved these changes
Oct 9, 2018
|
Thank you @Bunjin! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
100% coverage for French locale and a few typo fixes / rewording for more idiomatic expressions.
Fixes verify-locale-string.js fails when using a locale option #5457, an issue with verify-locale-strings.js when specifying a locale code, eg. node verify-locale-strings.js fr
Corrected a typo in English locale and also several reorderings to preserve alphabetical order.
Also this is my first PR after joining the Metamask team 🎉