Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4250 #5559

Merged
merged 6 commits into from
Oct 21, 2018
Merged

Fixes #4250 #5559

merged 6 commits into from
Oct 21, 2018

Conversation

trowacat
Copy link
Contributor

Localized language names as suggested in #4250.

kumavis
kumavis requested changes Oct 20, 2018
View reviewed changes
Copy link
Member

@kumavis kumavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually can see that Japanese is incorrect - which makes me suspect others may be as well

kumavis
kumavis previously approved these changes Oct 20, 2018
View reviewed changes
@kumavis
Copy link
Member

kumavis commented Oct 20, 2018

Cool, made some fixes and some changes that are hopefully improvements. Primarily used a wikipedia article's alternate languages list.

@kumavis
Copy link
Member

kumavis commented Oct 20, 2018

hmm build system is broken, fix is here #5561

@trowacat
Copy link
Contributor Author

@kumavis Thank you! I will make the addition of the fix you referenced later today.

@kumavis kumavis merged commit b53a1f4 into MetaMask:develop Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumavis kumavis kumavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trowacat @kumavis