fixed currency-display

[hackmod]

partial revert commit 99acde4

• call getValueFromWeiHex() with fromCurrency=nativeCurrency

@@ -24,7 +25,7 @@ const mergeProps = (stateProps, dispatchProps, ownProps) => {

   const toCurrency = currency || currentCurrency
   const convertedValue = getValueFromWeiHex({
-    value, toCurrency, conversionRate, numberOfDecimals, toDenomination: denomination,
+    value, fromCurrency: nativeCurrency, toCurrency, conversionRate, numberOfDecimals, toDenomination: denomination,
   })
   const displayValue = formatCurrency(convertedValue, toCurrency)
   const suffix = hideLabel ? undefined : toCurrency.toUpperCase()

[whymarrh]

@hackmod can you provide more detail about why/where this is needed? If anything we could pass fromCurrency: currency, no?

[hackmod]

I can confirm that the minimal fix is the following with clean setup,. so strange..

--- a/ui/app/components/currency-display/currency-display.container.js
+++ b/ui/app/components/currency-display/currency-display.container.js
@@ -24,7 +24,7 @@ const mergeProps = (stateProps, dispatchProps, ownProps) => {

   const toCurrency = currency || currentCurrency
   const convertedValue = getValueFromWeiHex({
-    value, toCurrency, conversionRate, numberOfDecimals, toDenomination: denomination,
+    value, fromCurrency: 'ETH', toCurrency, conversionRate, numberOfDecimals, toDenomination: denomination,
   })
   const displayValue = formatCurrency(convertedValue, toCurrency)
   const suffix = hideLabel ? undefined : toCurrency.toUpperCase()

screenshot

with this fix

without this fix

[whymarrh]

We can pull this from state above (in mapStateToProps) and then we shouldn't need a default

[hackmod]

yes. as you already mentioned and logically we don't have to apply this fix at all.
but as you can see, without this fix, currency-display do not show the correct value...

[hackmod]

drop last change

[hackmod]

last change seems no effect and formal fix looks redundant but it show correct value.

as you already pointed out fromCurrency: currency might be work logically but for currency == undefined case, currency-input show wrong value.

[whymarrh]

As noted above, we can pull this from state

[whymarrh]

Thanks