Fix etherscan links on notifications #5978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextsg
approved these changes
Dec 28, 2018
danfinlay
approved these changes
Dec 29, 2018
|
The drizzle tests seem to be blocking this with an error I get even when re-running: I guess we can figure out when the team re-convenes whether we should disable this test or there is a simple fix. |
|
I'll try re-running with SSH and digging around, this seems like it might be caused by something in the CircleCI image changing from underneath us (assuming we're using the same versions of everything). |
… fix-etherscan-link-notifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke since #5865
Anyway, there's no need to call MMC to open a window.