Harden Drizzle test runner script #5997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 938f428.
whymarrh
force-pushed
the
drizzle-script
branch
2 times, most recently
from
fdd9b3c to
1ea4671
Compare
whymarrh
force-pushed
the
drizzle-script
branch
from
1ea4671 to
4d4d4ca
Compare
tmashuang
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Bash script we're using to kick off the Drizzle tests, adding more error handling and cleaning up a few of the assumptions in the file. We no longer assume the location of the npm
.bindirectory and we're cleaning up after ourselves now when possible.