I#5956 fix 1 #6026
Merged
I#5956 fix 1 #6026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oller for custom rpcs
frankiebee
force-pushed
the
i#5956-fix1
branch
from
4d1ab14 to
adbd433
Compare
danfinlay
approved these changes
Jan 17, 2019
|
Looks like you'll need to pull in |
|
@danfinlay it's actually an issue with how the network dropdown works and this was a side affect bug. but the network dropdown fix is up next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a partial fix for #5956 but this is will prevent users from setting non number chainId's for custom rpcs as well as migrate storage to remove past NaN chainId's
fix two will be on it's way shortly hopefully fixing the caching problem