Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds e2e test for most web3 methods that dapps use #6160

Merged
merged 8 commits into from
Apr 16, 2019
Merged

Adds e2e test for most web3 methods that dapps use #6160

merged 8 commits into from
Apr 16, 2019

Conversation

Sneh1999
Copy link
Contributor

Created a schema.json file to accumulate all the web3 functions and group the ones which have similar output

@Sneh1999 Sneh1999 requested a review from danjm February 14, 2019 19:35
@metamaskbot
Copy link
Collaborator

Builds ready [f713814]: mascara, chrome, firefox, edge, opera

danjm
danjm requested changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments made with the intention of making this a little easier to read.

test/web3/schema.json Outdated Show resolved Hide resolved
test/web3/schema.json Outdated Show resolved Hide resolved
test/web3/schema.json Outdated Show resolved Hide resolved
test/web3/schema.json Outdated Show resolved Hide resolved
danjm
danjm reviewed Feb 21, 2019
View reviewed changes
test/web3/contract.js Outdated Show resolved Hide resolved
danjm
danjm requested changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the tests. Looks good!

I've left some comments on how the code can be improved. Let me know if you have questions.

test/e2e/beta/web3.spec.js Outdated Show resolved Hide resolved
test/e2e/beta/web3.spec.js Outdated Show resolved Hide resolved
test/e2e/beta/web3.spec.js Show resolved Hide resolved
test/e2e/beta/web3.spec.js Outdated Show resolved Hide resolved
test/e2e/beta/web3.spec.js Outdated Show resolved Hide resolved
test/web3/web3.js Outdated Show resolved Hide resolved
@danjm danjm force-pushed the web3methodstests branch from ebda11b to ced8a26 Compare April 15, 2019 15:53
@Sneh1999 Sneh1999 changed the title schema added Adds e2e test for most web3 methods that dapps use Apr 15, 2019
@metamaskbot
Copy link
Collaborator

Builds ready [13db98e]: chrome, firefox, edge, opera

@danjm
Copy link
Contributor

danjm commented Apr 16, 2019

This looks good now, merging!

@danjm danjm merged commit fb22fb1 into develop Apr 16, 2019
@danjm danjm mentioned this pull request Apr 17, 2019
Closed
@whymarrh whymarrh deleted the web3methodstests branch May 22, 2019 13:59
@Gudahtt Gudahtt mentioned this pull request Jan 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danjm danjm danjm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sneh1999 @metamaskbot @danjm