Prevent infura requests in e2e tests #6364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
force-pushed
the
prevent-infura-requests-e2e-tests
branch
from
5c6a69a to
b4cda20
Compare
whymarrh
force-pushed
the
prevent-infura-requests-e2e-tests
branch
3 times, most recently
from
5b72cba to
3275e77
Compare
danjm
force-pushed
the
prevent-infura-requests-e2e-tests
branch
from
4341917 to
70a03bd
Compare
…with accounts in earlier test runs
whymarrh
force-pushed
the
prevent-infura-requests-e2e-tests
branch
from
7a31b03 to
3113114
Compare
whymarrh
approved these changes
Mar 29, 2019
danjm
added a commit
that referenced
this pull request
Mar 29, 2019
vittominacori
added a commit
to vittominacori/metamask-extension
that referenced
this pull request
Apr 3, 2019
* 'master' of https://github.com/MetaMask/metamask-extension: (84 commits) Version 6.3.1 Check token name constants against the lower case methodData name in conf tx switch container. Ensure correct confirm screen in case of smartcontract check fail About tab copy changes; Update route for Info & Help in account menu (MetaMask#6356) Revert to providing inline defaults in getHexGasTotal and increaseLastGasPrice (MetaMask#6361) Further e2e fixes in wake of MetaMask#6364 and MetaMask#6367 (MetaMask#6374) Split e2e run-all commands onto multiple lines Run from-import e2e tests with additional account, to avoid conflict with accounts in earlier test runs Use localhost instead of mainnent/infura for custom rpc tests in e2e tests. ci: Add build:test Gulp task for e2e build e2e: Update Contract Interaction wording e2e: Skip approving token test send-footer.utils.js - addressIsNew - improve readability test - unit - ui - actions - setCompletedOnboarding - fix stub to call callback lint fix actions - setCompletedOnboarding - make async with pify notice-controller - make markAllNoticesRead sync lib - nodeify - correctly wrap synchronous functions notices - markAllNoticesRead - use async/await buy-eth-url - lint fix ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that we do not make any requests to infura in our current e2e tests. It makes two notable changes to achieve this:
webRequestAPI to cancel any network requests to infura.io domainsAn implication of this second item is that we cannot fully test the method name feature. An e2e test has had to be changed accordingly. A future improvement would be to add a local server to which we can redirect these requests.
One foundational change that this PR makes: a new script for creating a build specifically for e2e tests is added. This allows us to create a build where
webRequestBlockingis added to the permissions, without affecting prod. It also allows us to inject an env variable for identifying the environment as in test.What is missing is an addition of these scripts to the circleci run. @whymarrh I could use your help there.