-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Wyre Widget #6434
Adds Wyre Widget #6434
Conversation
@danjm if we're going to keep the Wyre script, we might be best to move it from |
@whymarrh Good suggestion, I will do that, if we decide to keep the code in our codebase Any thoughts on whether we should? My concern is that if we do we are subject to surprise breaking changes or subject our users to using outdated features/api/UX I don't really want to load the code from a remote host at runtime either though... |
@whymarrh In the latest commit I moved the wyre code to a vendor directory as you suggested. |
Couldn't finish the flow, since the phone verification wasn't working. |
This comment has been minimized.
This comment has been minimized.
Here is a demo video: https://streamable.com/k66vl |
Sorry for the delay. When I got to the end of the flow, I saw this error I never saw the "connect" screen at the beginning of the flow, I clicked "connect with MetaMask" and was immediately brought to the next step. After clearing privacy data and trying again, I saw the connect popup and did not see this error on the final screen. |
@danjm seems this has gone stale -- mostly ready? |
f773588
to
81021f7
Compare
Builds ready [d6623a9]
|
d6623a9
to
58e72f4
Compare
f89aaee
to
a2d7e97
Compare
41fae32
to
00db455
Compare
Builds ready [00db455]
|
00db455
to
9142f6c
Compare
Builds ready [9142f6c]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Adds Wyre widget to the deposit modal. * Move wyre widget code to vendor directory * Get Wyre widget working without metamask connect/sign steps * Code cleanup for wyre changes * Change wyre widget to using prod environment * Remove code allowing signing of wyre messages without confirmations * Update wyre vendor code for wyre 2.0 * Remove unnecessary changes to provider approval constructor, triggerUI and openPopup * Fix Wyre translation message * Delete no longer used signature-request-modal * Fix documentation of matches function in utils/util.js * Code cleanup on wyre branch * Remove front end code changes not needed to support wyre v2
This reverts commit 6a4df0d.
fixes #5260
This PR adds the Wyre widget debit card widget to metamask for use as a crypto onramp.
Some notable aspects to this PR:
when a signature request is made by the wyre widget, metamask will show a new "Signature Request Modal", this will be layered above the widget
when we attempt to open the widget from the popup view, the extension is opened in full screen on the new DEPOSIT_ROUTE, which triggers an opening of the widget of the widget
This PR still needs a QA that goes all the way through wyre onboarding process. The following test data can be used:
I guess we also need to load the script at run time, instead of copying the script code into our codebase... really I just wish it was an npm module