Address prop types errors #6481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If all tokens have decimal properties of type |
|
@whymarrh To accomodate users who already have one our the other saved to state |
although, perhaps that means we need a migration... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes first two items of #6474
The first was caused by the existence of both number and string
decimalsin thestate.metamask.tokenslist. #6475 doesn't fully fix the issue, because depending on how a token is added to the list, the decimals could be a string and not a number.This PR fixes this by allowing decimals to be either string or number. In addition, this PR gets to the root of the issue by ensuring that all tokens in our list have
decimalsproperties of typeNumber. These fixes are made in 8a82e62The second item of #6474 is fixed in 8c075b7 The provider was always receiving objects for its
activeCurrencyprop because of a bug in thegetSelectedAssetselector. This is corrected so that the selector only returns token symbol strings, not whole objects.