Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New custom rpc form designs #6483

Closed
wants to merge 21 commits into from
Closed

New custom rpc form designs #6483

wants to merge 21 commits into from

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Apr 18, 2019

resolves #6209

This PR implements the new designs for the Custom RPC form. Gifs of usage are below

Peek 2019-04-18 13-40

Peek 2019-04-18 13-48

@danjm danjm requested a review from whymarrh as a code owner April 18, 2019 16:21
@danjm danjm requested a review from cjeria April 18, 2019 16:21
@danjm
Copy link
Contributor Author

danjm commented Apr 18, 2019

Todo:

  • update e2e tests
  • remove back button from settings header
  • update/add header+subheaders on other tabs

@danjm danjm force-pushed the custom-rpc-form-updates branch from 15e3a13 to e871049 Compare April 18, 2019 16:26
@danjm danjm force-pushed the custom-rpc-form-updates branch from e871049 to d523d9d Compare April 19, 2019 05:28
@danjm danjm force-pushed the custom-rpc-form-updates branch from d523d9d to 817f4c2 Compare April 22, 2019 16:54
@danjm
Copy link
Contributor Author

danjm commented Apr 29, 2019

All changes here are included in #6490, so closing this in favour of that.

@danjm danjm closed this Apr 29, 2019
@whymarrh whymarrh deleted the custom-rpc-form-updates branch May 9, 2019 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to Custom RPC form
1 participant