Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 6.7.0 RC1 #6723

Closed
wants to merge 3 commits into from
Closed

Version 6.7.0 RC1 #6723

wants to merge 3 commits into from

Conversation

danfinlay
Copy link
Contributor

Up for QA, for a possible June 24 release.

tmashuang and others added 3 commits June 17, 2019 10:43
* Adds 4byte registry fallback to getMethodData() (#6435)

* Adds fetchWithCache to guard against unnecessary API calls

* Add custom fetch wrapper with abort on timeout

* Use opts and cacheRefreshTime in fetch-with-cache util

* Use custom fetch wrapper with timeout for fetch-with-cache

* Improve contract method data fetching (#6623)

* Remove async call from getTransactionActionKey()

* Stop blocking confirm screen rendering on method data loading, and base screen route on transactionCategory

* Remove use of withMethodData, fix use of knownMethodData, in relation to transaction-list-item.component

* Load data contract method data progressively, making it non-blocking; requires simplifying conf-tx-base lifecycle logic.

* Allow editing of gas price while loading on the confirm screen.

* Fix transactionAction component and its unit tests.

* Fix confirm transaction components for cases of route transitions within metamask.

* Only call toString on id if truthy in getNavigateTxData()

* Fix knownMethodData retrieval and data fetching from fourbyte
@danfinlay danfinlay requested a review from tmashuang June 18, 2019 15:48
@metamaskbot
Copy link
Collaborator

Builds ready [54bfe0f]: chrome, firefox, edge, opera

@danfinlay danfinlay changed the base branch from develop to master June 19, 2019 20:52
@tmashuang tmashuang mentioned this pull request Jun 25, 2019
@tmashuang
Copy link
Contributor

#6749 was merged.

@tmashuang tmashuang closed this Jun 27, 2019
@whymarrh whymarrh deleted the Version-6.7.0 branch November 19, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants