Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor account-details-modal #6751

Merged

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 25, 2019

Refactor the AccountDetailsModal to follow newer conventions. Changes include:

  • Create a directory for the component with separate files for the
    component, the container, and the entrypoint.
  • Use jsx rather than hyperscript

Fixes #6741

@Gudahtt Gudahtt requested review from danjm and whymarrh as code owners June 25, 2019 22:34
@Gudahtt Gudahtt force-pushed the i6741-refactor-account-details-modal branch from ecd8eb4 to 0e94763 Compare June 25, 2019 22:37
Refactor the AccountDetailsModal to follow newer conventions. Changes
include:
- Create a directory for the component with separate files for the
  component, the container, and the entrypoint.
- Use jsx rather than hyperscript

Fixes MetaMask#6741
@Gudahtt Gudahtt force-pushed the i6741-refactor-account-details-modal branch from 0e94763 to 8b83b1c Compare June 25, 2019 22:38
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@Gudahtt Gudahtt merged commit 6d191f2 into MetaMask:develop Jun 27, 2019
@Gudahtt Gudahtt deleted the i6741-refactor-account-details-modal branch July 5, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor account-details-modal.js
2 participants