Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master => develop #6765

Merged
merged 19 commits into from
Jul 1, 2019
Merged

Master => develop #6765

merged 19 commits into from
Jul 1, 2019

Conversation

danfinlay
Copy link
Contributor

@danfinlay danfinlay commented Jun 28, 2019

Bring version bumps up into develop.

Opening this largely to see if this flow could be feasible, and what it might look like:

  • Develop stays ahead
  • RCs branch off Develop
  • At point of deploy, RCs merge to master
  • master is regularly merged back into develop.

This way, develop only gets its version info from master, and version info is only created on RC branches.

Downside: We get all these merge pull request commits. Also if we squash & merge this (our default automatic merge option), we probably won't be able to merge it again automatically.

@danfinlay danfinlay requested review from danjm and whymarrh as code owners June 28, 2019 05:44
@danfinlay danfinlay changed the title Master Master => develop? Jun 28, 2019
@metamaskbot
Copy link
Collaborator

Builds ready [27a572d]: chrome, firefox, edge, opera

@danfinlay
Copy link
Contributor Author

Publish release script error:

ERROR: The key you are authenticating with has been marked as read only.
fatal: Could not read from remote repository.

tmashuang
tmashuang previously approved these changes Jun 28, 2019
@metamaskbot
Copy link
Collaborator

Builds ready [27a572d]: chrome, firefox, edge, opera

The MetaMask bot is currently failing to publish docs updates, and it is
[blocking our ability to release new
versions](#6765).

While we should pursue a proper fix, I think it's worth disabling in the
meanwhile so this glitch doesn't interfere with our regular release
cadence further.
Disable release script from CircleCI
@metamaskbot
Copy link
Collaborator

Builds ready [a6efa7a]: chrome, firefox, edge, opera

@danfinlay danfinlay changed the title Master => develop? Master => develop Jul 1, 2019
.circleci/config.yml Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [743afd4]: chrome, firefox, edge, opera

@danfinlay danfinlay merged commit 4487203 into develop Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants