Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use latest signTypedData version from eth-sig-util #6930

Merged
merged 1 commit into from
Aug 20, 2019
Merged

use latest signTypedData version from eth-sig-util #6930

merged 1 commit into from
Aug 20, 2019

Conversation

BrendanChou
Copy link

This supports arrays in signing of typed data

fixes #6868
fixes #6106

@whymarrh whymarrh requested review from bitpshr and danfinlay July 30, 2019 00:44
danfinlay
danfinlay requested changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@danfinlay danfinlay left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of the v3 suffix is to avoid breaking changes. Rather than changing the behavior of this method, we should add a case 'V4' which will use the new method.

@BrendanChou BrendanChou reopened this Aug 16, 2019
@BrendanChou
Copy link
Author

Ready for another look

danfinlay
danfinlay reviewed Aug 20, 2019
View reviewed changes
Copy link
Contributor

@danfinlay danfinlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thank you so much for contributing this, we weren't able to fit it into this sprint. Could I get a UI team member, maybe @Gudahtt to do an additional sanity check/approval?

whymarrh
whymarrh approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whymarrh whymarrh merged commit cc71b4f into MetaMask:develop Aug 20, 2019
@BrendanChou BrendanChou deleted the patch-1 branch August 20, 2019 20:03
@whymarrh whymarrh mentioned this pull request Aug 20, 2019
Merged
@bbondy bbondy mentioned this pull request Dec 16, 2019
Closed
@mds1 mds1 mentioned this pull request Apr 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@danfinlay danfinlay danfinlay approved these changes

@bitpshr bitpshr bitpshr approved these changes

@danjm danjm Awaiting requested review from danjm

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for signTypedData_v4 Array support in encodeData for EIP712 signature.
4 participants
@BrendanChou @bitpshr @danfinlay @whymarrh