Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address book fixes #6978

Merged
merged 4 commits into from
Aug 13, 2019
Merged

Address book fixes #6978

merged 4 commits into from
Aug 13, 2019

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Aug 8, 2019

This PR fixes two address book related issues:

  • prior to this PR, if sending to an ENS address and assigning that address with a specific name, the to input would not update to the new name and the new address dialoag would not go away even when the name is added
  • all addressbook additions would cause a "address book not set" warning to be shown in the settings screen

@danjm danjm requested review from Gudahtt and whymarrh as code owners August 8, 2019 18:51
@metamaskbot
Copy link
Collaborator

Builds ready [1441a0e]: chrome, firefox, edge, opera

Gudahtt
Gudahtt reviewed Aug 9, 2019
View reviewed changes
ui/app/store/actions.js Outdated Show resolved Hide resolved
@danjm danjm force-pushed the addressbook-fixes branch 3 times, most recently from 8c2f3bf to ded495b Compare August 13, 2019 03:47
@whymarrh
Copy link
Contributor

Refs MetaMask/core#143

Do we want to wait for a release and update our GABA version?

@danjm danjm force-pushed the addressbook-fixes branch from ded495b to a267a79 Compare August 13, 2019 16:06
@metamaskbot
Copy link
Collaborator

Builds ready [a267a79]: chrome, firefox, edge, opera

whymarrh
whymarrh approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Gudahtt
Gudahtt approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍 to using selectors to replace/reduce the logic in the component render.

@danjm danjm merged commit 043920c into develop Aug 13, 2019
@whymarrh whymarrh deleted the addressbook-fixes branch August 14, 2019 12:32
@bbondy bbondy mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danjm @metamaskbot @whymarrh @Gudahtt