Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: block ERC721 on mobile sync #7035

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

estebanmino
Copy link
Contributor

This PR blocks ERC721 assets to be sync with mobile. There are some ERC721 assets handled as ERC20 so I added a filter to block mainnet assets that we know are ERC721, in order to not send non useful data.

@metamaskbot
Copy link
Collaborator

Builds ready [476e56c]: chrome, firefox, edge, opera

Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whymarrh whymarrh merged commit 6e081eb into develop Aug 20, 2019
@whymarrh whymarrh deleted the bugfix/block-erc721-on-mobile-sync branch August 20, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants