Fix phishing detect script #7287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
force-pushed
the
fix-phishing-detect
branch
from
33c4a6c to
69a9576
Compare
Gudahtt
previously approved these changes
Oct 17, 2019
|
It would be nice to add a test for this though eh. |
whymarrh
force-pushed
the
fix-phishing-detect
branch
from
69a9576 to
5f57cea
Compare
|
@Gudahtt test added, good catch! |
Gudahtt
previously approved these changes
Oct 18, 2019
whymarrh
force-pushed
the
fix-phishing-detect
branch
from
5f57cea to
33b465f
Compare
Gudahtt
approved these changes
Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7100
This PR fixes the "continuing at your own risk" link on the phishing page, which has been broken since v7.0.1 where we introduced 12e055a via #6966.
The result of
getEnvironmentType(the value ofwindowType) used in the phishing detect script changed in the above commit and resulted in a connection to the incorrect context.