Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix positioning of tx status in tx-list #7319

Merged
merged 1 commit into from
Oct 28, 2019
Merged

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Oct 28, 2019

Fixes #7036
Closes #7272

This PR fixes the height placement of the status indicator within transaction list items. This issue was introduced with c05090a

The additional div added on line 88 of the identicon component causes the grid row in the tx list to expand to the height of the identicon. Previously, the identicon was overflowing into the next row.

This PR explicitly sets the height of the relevant row, preventing problems from heights of grid cells.

Screenshots:
Screenshot from 2019-10-28 17-43-49
Screenshot from 2019-10-28 17-43-35

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [56c78fb]

@danjm danjm merged commit b89d96e into develop Oct 28, 2019
@whymarrh whymarrh deleted the fix-tx-list-identicon-height branch October 29, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Padding in TX History
4 participants