Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update json-rpc-engine #7390

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Update json-rpc-engine #7390

merged 2 commits into from
Nov 12, 2019

Conversation

rekmarks
Copy link
Member

Add json-rpc-engine@5.1.5 which supports ordered batch requests.

All other production dependencies use json-rpc-engine@^5.1.3. Do they need to be updated as well or should semver cover for us here?

danfinlay
danfinlay previously approved these changes Nov 12, 2019
@metamaskbot
Copy link
Collaborator

Builds ready [19dc390]

danfinlay
danfinlay previously approved these changes Nov 12, 2019
@metamaskbot
Copy link
Collaborator

Builds ready [36acd5a]

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@metamaskbot
Copy link
Collaborator

Builds ready [eae8295]

@rekmarks rekmarks merged commit ce7f516 into develop Nov 12, 2019
@whymarrh whymarrh deleted the update-rpc-engine branch November 13, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants