Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional rpcUrl verification #7436

Merged
merged 9 commits into from
Nov 19, 2019
Merged

Add additional rpcUrl verification #7436

merged 9 commits into from
Nov 19, 2019

Conversation

rickycodes
Copy link
Contributor

@rickycodes rickycodes commented Nov 15, 2019 •
edited
Loading

closes: #7388

This adds additional verification so an existing rpcUrl cannot be added as part of a new network (thus ensuring our "key" is always unique).

image

Wording might need to be changed

@rickycodes rickycodes changed the title Add additional url verification Add additional rpcUrl verification Nov 15, 2019
Gudahtt
Gudahtt previously approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

Ideally we would allow networks with the same URL, but this seems like the best solution for now.

Gudahtt
Gudahtt previously approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

Gudahtt
Gudahtt approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rickycodes rickycodes merged commit 346c1f2 into MetaMask:develop Nov 19, 2019
@bbondy bbondy mentioned this pull request Dec 16, 2019
Closed
@rickycodes rickycodes deleted the issue-7388 branch February 12, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@danjm danjm Awaiting requested review from danjm

@whymarrh whymarrh Awaiting requested review from whymarrh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rickycodes @Gudahtt