Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add migration notification for users with non-zero Sai #7450

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Add migration notification for users with non-zero Sai #7450

merged 1 commit into from
Nov 18, 2019

Conversation

whymarrh
Copy link
Contributor

@whymarrh whymarrh commented Nov 16, 2019 •
edited
Loading

Closes #7411

Context

Maker has upgraded its Dai token to "Multi-Collateral Dai" (MCD) and requires all users interacting with Dai migrate their tokens to the new version. Dai now exclusively refers to Multi-Collateral Dai and what was previouly called Dai is now Sai (Single Collateral Dai).

In this description, Sai refers to what was (prior to the 2019-11-18) known as Dai. Dai is the new token.

This Pull Request

This changeset:

  1. Only affects users who had non-zero Sai at the old contract address
  2. Displays a persistent notification for users with Sai
  3. Updates the token symbol for users already tracking the Sai token
  4. Bumps our direct and indirect eth-contract-metadata dependencies

The notification copy:

Dai is now "Sai" and Maker would like you upgrade your Sai tokens

I've updated the copy from the issue to clarify to unknowing users what the transition is.

Going Forward

Users with non-zero Sai will now see Sai in their token lists. New users of Sai and Dai will be able to add and track either manually (or both at the same time).

Screen Shot 2019-11-16 at 19 59 54

Screen Shot 2019-11-16 at 20 00 25

@whymarrh
Copy link
Contributor Author

This is in draft until 2019-11-18 when the migration website goes live

@whymarrh whymarrh force-pushed the mkr-migration branch 2 times, most recently from f092eb8 to 6efec31 Compare November 16, 2019 23:34
@whymarrh
Copy link
Contributor Author

I can use the copy from the issue but I propose this copy as it's a little more clear as to what is going on, esp. for users who were previously unaware.

@whymarrh whymarrh marked this pull request as ready for review November 18, 2019 15:10
@tmashuang
Copy link
Contributor

tmashuang commented Nov 18, 2019 •
edited
Loading

Related to #7460, and potentially making this PR non informative.

@whymarrh whymarrh force-pushed the mkr-migration branch 2 times, most recently from e4e9b47 to dfb8e95 Compare November 18, 2019 18:28
@whymarrh
Copy link
Contributor Author

@tmashuang good catch! Let me see if I can fix that too!

@whymarrh
Copy link
Contributor Author

I've updated the copy to the following (cc @bdresser)

A message from the Maker team: it looks like you have some Dai in your account. You need to migrate this Dai to its new version or it will be deprecated.

Note that we are renaming Dai to Sai in this PR as per Maker's migration guide, 🤷🏽‍♂️, so that's maybe confusing.

@whymarrh whymarrh force-pushed the mkr-migration branch 2 times, most recently from e158a52 to 4969f78 Compare November 18, 2019 18:51
@lassebirk
Copy link

lassebirk commented Nov 18, 2019 •
edited
Loading

@whymarrh
Lasse from Maker here. Can I propose this messaging:

A message from Maker: The new Multi-Collateral Dai token has been released. Your old tokens are now called Sai. Please upgrade your Sai tokens to the new Dai. [BUTTON]

@whymarrh
Copy link
Contributor Author

@lassebirk I've updated the copy, thanks

bdresser
bdresser previously approved these changes Nov 18, 2019
View reviewed changes
@whymarrh
Add migration notification for users with Sai
14a2447 
Maker has upgraded its Dai token to "Multi-Collateral Dai" (MCD) and requires
all users interacting with Dai migrate their tokens to the new version. Dai
now exclusively refers to Multi-Collateral Dai and what was previouly called
Dai is now Sai (Single Collateral Dai).

In this description, Sai refers to what was (prior to the 2019-11-18) known as Dai.
Dai is the _new_ token.

This changeset:

1. Only affects users who had non-zero Sai at the old contract address
2. Displays a persistent notification for users with Sai
3. Updates the token symbol for users already tracking the Sai token
4. Bumps our direct and indirect eth-contract-metadata dependencies

The notification copy:

> Dai is now "Sai" and Maker would like you upgrade your Sai tokens

I've updated the copy from the issue to clarify to unknowing users what the
transition is.
Gudahtt
Gudahtt approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

tmashuang
tmashuang approved these changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@tmashuang tmashuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whymarrh whymarrh merged commit 86b165e into MetaMask:develop Nov 18, 2019
@whymarrh whymarrh deleted the mkr-migration branch November 18, 2019 21:46
@bbondy bbondy mentioned this pull request Dec 16, 2019
Closed
@whymarrh whymarrh mentioned this pull request Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmashuang tmashuang tmashuang approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@bdresser bdresser bdresser approved these changes

@rickycodes rickycodes Awaiting requested review from rickycodes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Help users update to SAI
5 participants
@whymarrh @tmashuang @lassebirk @bdresser @Gudahtt