updating root readme #7480
Merged
updating root readme #7480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, new to doing PRs on open source and wasn't sure which type of PR to create. I know it says don't merge but I didn't know how else to create a PR. I will do better next time! |
Gudahtt
approved these changes
Nov 20, 2019
There was a problem hiding this comment.
I'm not sure you mean when you say that it says "don't merge" - do you mean the "Merging is blocked" message? That's just GitHub saying that one of us needs to review the change first - that's perfectly normal.
This looks good, thanks! That script could certainly use a comment block at the top to explain what it does, as you mentioned in the issue, but this is a strict improvement.
|
Thanks @afmsavage! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the root repo
README.mdto the correct link on visualizing the repo's development.Fixes #7471