Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use localized messages for NotificationModal buttons #7558

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Use localized messages for NotificationModal buttons #7558

merged 1 commit into from
Nov 25, 2019

Conversation

whymarrh
Copy link
Contributor

Refs #7550

This PR updates the buttons in the NotificationModal component to use localized messages for confirm and cancel.

Gudahtt
Gudahtt approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I had noticed a few messages in the components being refactored weren't localized.

@whymarrh whymarrh merged commit caefda5 into MetaMask:develop Nov 25, 2019
@whymarrh whymarrh deleted the NotificationModal-words branch November 25, 2019 13:32
Gudahtt pushed a commit that referenced this pull request Dec 5, 2019
@whymarrh @Gudahtt
Use localized messages for NotificationModal buttons (#7558)
d605fa5
@bbondy bbondy mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@rickycodes rickycodes Awaiting requested review from rickycodes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whymarrh @Gudahtt