Handle one specific permissions request per tab #7620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [97b5093]
|
danjm
reviewed
Dec 3, 2019
| const permissionsRequests = getPermissionsRequests(state) | ||
|
|
||
| const permissionsRequest = permissionsRequests | ||
| .find(permissionsRequest => permissionsRequest.metadata.id === permissionsRequestId) |
There was a problem hiding this comment.
Not sure if we can assume that permissionsRequest.metadata will always be an object
There was a problem hiding this comment.
I think we can. This is the only place requests are added: https://github.com/MetaMask/rpc-cap/blob/master/index.ts#L817
There was a problem hiding this comment.
Yeah, that rpc-cap metadata has not been a problem historically. Site/domain metadata in the permissions middleware has caused trouble by not existing (ごめんなさい 🙇).
danjm
reviewed
Dec 3, 2019
The connect route now takes a route parameter: the permissions request id. This id is set whenever the permissions connect screen is opened, ensuring that that tab is for that specific request alone. This makes handling of multiple permissions requests a bit more intuitive. Previously whenever opening multiple permissions requests, the first one would be shown on each successive tab, whereas you would expect each tab to show the request that prompted the tab to open. Users may now address permissions request in whichever order they'd like to, rather than being forced to deal with them chronologically.
Gudahtt
force-pushed
the
LoginPerSite-one-request-per-tab
branch
from
97b5093 to
5f8ceca
Compare
Builds ready [5f8ceca]
|
Gudahtt
requested review from
danfinlay,
danjm and
rekmarks
and removed request for
frankiebee
danjm
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connect route now takes a route parameter: the permissions request id. This id is set whenever the permissions connect screen is opened, ensuring that that tab is for that specific request alone.
This makes handling of multiple permissions requests a bit more intuitive. Previously whenever opening multiple permissions requests, the first one would be shown on each successive tab, whereas you would expect each tab to show the request that prompted the tab to open. Users may now address permissions request in whichever order they'd like to, rather than being forced to deal with them chronologically.