Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust colour of Reset Account btn to reflect danger #7696

Merged
merged 1 commit into from
Dec 12, 2019

Conversation

whymarrh
Copy link
Contributor

This PR updates the colour of the Reset Account button in settings, and its confirmation modal confirm button. As suggested by @cjeria in #7686.

Before (expand) Screen Shot 2019-12-12 at 13 18 18 Screen Shot 2019-12-12 at 13 58 11

After:
Screen Shot 2019-12-12 at 13 58 24
Screen Shot 2019-12-12 at 13 58 27

@whymarrh
Copy link
Contributor Author

whymarrh commented Dec 12, 2019

I'd argue that we could also move this to the bottom of the page since this has a hyper-specific use case. It doesn't really need to be above the fold.

Edit: but that's a separate change

Copy link
Contributor

@rickycodes rickycodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cjeria cjeria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@cjeria cjeria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@whymarrh whymarrh merged commit 4b471a4 into MetaMask:develop Dec 12, 2019
@whymarrh whymarrh deleted the red-reset branch December 12, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants