Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct network-tabdefaultNetworksData chainID #7762

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Correct network-tabdefaultNetworksData chainID #7762

merged 1 commit into from
Jan 8, 2020

Conversation

SiriusTsou
Copy link
Contributor

Rinkeby ChainID and Kovan ChainID are incorrect.

@whymarrh
Copy link
Contributor

whymarrh commented Jan 8, 2020

I can confirm that the Rinkeby chainId is indeed 4 and Kovan is indeed 42.[1][2][3][4]

whymarrh
whymarrh approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @SiriusTsou!

@whymarrh whymarrh merged commit 9ba3774 into MetaMask:develop Jan 8, 2020
yqrashawn added a commit to yqrashawn/conflux-portal that referenced this pull request Jan 14, 2020
@yqrashawn
Fix: Kovan and Rinkeby chain IDs (MetaMask#7762)
912c185
yqrashawn added a commit to Conflux-Chain/conflux-portal that referenced this pull request Jan 15, 2020
@yqrashawn
Fix: Kovan and Rinkeby chain IDs (MetaMask#7762)
4c1f48e
@Gudahtt Gudahtt mentioned this pull request Apr 29, 2020
Merged
Gudahtt pushed a commit that referenced this pull request Apr 29, 2020
@SiriusTsou @Gudahtt
Backport "Fix Kovan and Rinkeby chain IDs (#7762)"
e77581a 
Backport #7762 to v7.7.9
Gudahtt added a commit that referenced this pull request Apr 29, 2020
@Gudahtt @SiriusTsou
Backport "Fix Kovan and Rinkeby chain IDs (#7762)" (#8462)
8a8c774 
Backport #7762 to v7.7.9

Co-authored-by: Sirius Tsou <sirius.tsou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@danjm danjm Awaiting requested review from danjm

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SiriusTsou @whymarrh