Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge xtend from the background scripts #7796

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

whymarrh
Copy link
Contributor

@whymarrh whymarrh commented Jan 9, 2020

Similar to #7795

This PR removes xtend usages, replacing them with a shallow copy via the spread syntax (or Object.assign where that's a cleaner diff). This functionality doesn't require an external library anymore.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frankiebee frankiebee merged commit 25fe4ad into MetaMask:develop Jan 13, 2020
@whymarrh whymarrh deleted the purge-xtend branch January 14, 2020 16:21
yqrashawn pushed a commit to yqrashawn/conflux-portal that referenced this pull request Jan 15, 2020
yqrashawn pushed a commit to Conflux-Chain/conflux-portal that referenced this pull request Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants