Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wyre ETH purchase url #8051

Merged
merged 2 commits into from
Feb 14, 2020
Merged

Update Wyre ETH purchase url #8051

merged 2 commits into from
Feb 14, 2020

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 14, 2020

This reverts commit bc67d1e (#7631), which was a revert of 015ba83 (#7482)

The new hosted widget is now used for Wyre deposits. It appears to allow payment with either Apple pay, or debit (in certain U.S. states only). This has not yet been tested.

@metamaskbot
Copy link
Collaborator

Builds ready [5762612]
Page Load Metrics (693 ± 24 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint36120622311
domContentLoaded6207876914924
load6227896934924
domInteractive6207876915024

@Gudahtt
Copy link
Member Author

Gudahtt commented Feb 14, 2020

Apply Pay apparently only works on Safari, so the purchase URL has been updated to restrict payments to debit only.

@metamaskbot
Copy link
Collaborator

Builds ready [68827b2]
Page Load Metrics (606 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint34109552612
domContentLoaded3537216059646
load3557226069646
domInteractive3537206059646

Copy link
Contributor

@tmashuang tmashuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, successfully opens widget in a tab and uses debit card to purchase ETH. Also, uses SMS validation for transaction. Issue at the end of the payment confirmation that doesn't allow us to close the widget, probably since it is in a tab, have to manually close the tab from the tab bar.

@tmashuang tmashuang merged commit 62c5ea4 into develop Feb 14, 2020
@tmashuang tmashuang deleted the update-wyre-url branch February 14, 2020 22:07
Gudahtt added a commit that referenced this pull request Feb 14, 2020
* Revert "Revert "Update Wyre ETH purchase url" (#7631)"

This reverts commit bc67d1e.

* Restrict widget to just debit card payments

Apple Pay apparently only works on Safari.
yqrashawn pushed a commit to yqrashawn/conflux-portal that referenced this pull request Feb 17, 2020
* Revert "Revert "Update Wyre ETH purchase url" (MetaMask#7631)"

This reverts commit bc67d1e.

* Restrict widget to just debit card payments

Apple Pay apparently only works on Safari.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants