Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle and set gas estimation when max mode is clicked #8176

Merged
merged 7 commits into from
Mar 11, 2020
Merged

Handle and set gas estimation when max mode is clicked #8176

merged 7 commits into from
Mar 11, 2020

Conversation

tmashuang
Copy link
Contributor

Add componentDidMount to SendAmountRow component to check for maxMode boolean to update amount and gas.

@tmashuang
Copy link
Contributor Author

Did this to master branch, since we might want to include this in the next release. Can change to develop.

@tmashuang
Copy link
Contributor Author

Fixes #8136 OP
Fixes #8055

@metamaskbot
Copy link
Collaborator

Builds ready [cfdba44]

@Gudahtt
Copy link
Member

Gudahtt commented Mar 11, 2020 •
edited
Loading

Did this to master branch, since we might want to include this in the next release. Can change to develop.

Since it has to land on develop too, I'd recommend targeting develop. It's either that or create a second PR for develop, since we won't be merging master into develop for a while yet.

We can still pull this into an RC branch based on master fairly easily

@tmashuang tmashuang changed the base branch from master to develop March 11, 2020 02:24
@tmashuang tmashuang changed the base branch from develop to master March 11, 2020 02:24
@tmashuang tmashuang force-pushed the max-mode-update-gas branch from cfdba44 to ea5cc17 Compare March 11, 2020 02:34
@tmashuang tmashuang closed this Mar 11, 2020
@tmashuang tmashuang deleted the max-mode-update-gas branch March 11, 2020 02:34
@tmashuang tmashuang restored the max-mode-update-gas branch March 11, 2020 02:35
@tmashuang tmashuang reopened this Mar 11, 2020
@tmashuang tmashuang changed the base branch from master to develop March 11, 2020 02:35
@metamaskbot
Copy link
Collaborator

Builds ready [5bb934b]
Page Load Metrics (747 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaintNaNNaNNaNNaNNaN
domContentLoaded62110267459144
load62310347479244
domInteractive62110267459144

@tmashuang
Copy link
Contributor Author

tmashuang commented Mar 11, 2020 •
edited
Loading

Now also handles the case of maxModeOn and a token is selected to render the correct Send Amount value in the customize gas modal page. Described here #8136 (comment)

@metamaskbot
Copy link
Collaborator

Builds ready [c97e6ec]
Page Load Metrics (642 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint36114582914
domContentLoaded3587996419948
load3598036429948
domInteractive3587986409948

@metamaskbot
Copy link
Collaborator

Builds ready [2264de8]
Page Load Metrics (568 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint338440105
domContentLoaded32869256711756
load33369456811756
domInteractive32869256611756

@tmashuang tmashuang requested a review from Gudahtt March 11, 2020 08:21
@tmashuang tmashuang force-pushed the max-mode-update-gas branch from da28749 to 15a7503 Compare March 11, 2020 18:41
@metamaskbot
Copy link
Collaborator

Builds ready [15a7503]
Page Load Metrics (675 ± 62 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint36121632914
domContentLoaded40188067312861
load40388267512862
domInteractive40188067312861

Gudahtt
Gudahtt previously approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmashuang @whymarrh
Fix && syntax
c809a74 
Co-Authored-By: Whymarrh Whitby <whymarrh.whitby@gmail.com>
@metamaskbot
Copy link
Collaborator

Builds ready [c809a74]
Page Load Metrics (607 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeNotificationfirstPaint3411445178
domContentLoaded33680560614168
load33880760714168
domInteractive33680560514168

@tmashuang tmashuang merged commit e791882 into develop Mar 11, 2020
@tmashuang tmashuang deleted the max-mode-update-gas branch March 11, 2020 20:13
This was referenced Mar 11, 2020
Closed
Closed
Gudahtt pushed a commit that referenced this pull request Mar 11, 2020
@tmashuang @Gudahtt
Handle and set gas estimation when max mode is clicked (#8176)
2f7db58 
* Handle and set gas estimation when max mode is clicked
Add componentDidMount to SendAmountRow to check for maxMode boolean to update amount and gas.
@jennypollack jennypollack mentioned this pull request Mar 17, 2020
Closed
@tmashuang tmashuang mentioned this pull request Mar 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

@danjm danjm Awaiting requested review from danjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmashuang @metamaskbot @Gudahtt @whymarrh