-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connected indicator info popup #8293
Conversation
Builds ready [c85a390]
Page Load Metrics (659 ± 54 ms)
|
fa1501d
to
4c01f56
Compare
Note that we only want to show this to existing users, not new users, so this should default to "shown". We'll have to add a migration to set it to "false", so existing users see it once. |
4c01f56
to
d056126
Compare
a5917d9
to
093402d
Compare
Builds ready [093402d]
Page Load Metrics (645 ± 59 ms)
|
cd231a3
to
16e4d44
Compare
ade401d
to
593fdff
Compare
Builds ready [593fdff]
Page Load Metrics (801 ± 89 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found a few more minor things. I haven't tested this locally yet to see how it looks, but I'll do that tomorrow.
Builds ready [9bfe721]
Page Load Metrics (610 ± 48 ms)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
button { | ||
height: 39px; | ||
width: 133px; | ||
border-radius: 39px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It looks a bit strange to have just this button rounded, while the rest are still rectangular. I know this matches the design, but there's a separate ticket to update the button designs across the entire app, and that would seem like the better time to make the buttons rounded rather than doing it in just this one place.
9bfe721
to
e3735f8
Compare
Builds ready [e3735f8]
|
This PR adds the popover containing info on the connected status indicator. It is intended to be shown to the user the first time they see it, but no more after that. Figma: https://www.figma.com/file/CvD7nhQVeSEB1QuSy3XhtY/oCap-%2F-Login-Per-Site?node-id=952%3A512
Demo video: https://streamable.com/n5k7kd