Snapshot txMeta without cloning history #8363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whymarrh
force-pushed
the
snapshot-tx-perf
branch
2 times, most recently
from
a31d0e0 to
45e7a56
Compare
|
nit: even better would be to have |
whymarrh
force-pushed
the
snapshot-tx-perf
branch
from
45e7a56 to
e50f410
Compare
|
@kumavis updated |
jennypollack
approved these changes
Apr 20, 2020
Gudahtt
pushed a commit
that referenced
this pull request
Apr 29, 2020
Backport #8363 to v7.7.9. Note that this uses `clone` instead of `cloneDeep`, because `clone` hadn't yet been replaced by `cloneDeep` on `master`. Backporting that change as well would have been very disruptive, so I've updated this to use `clone` instead to minimize conflicts. It is functionally equivalent.
Gudahtt
added a commit
that referenced
this pull request
Apr 29, 2020
Backport #8363 to v7.7.9. Note that this uses `clone` instead of `cloneDeep`, because `clone` hadn't yet been replaced by `cloneDeep` on `master`. Backporting that change as well would have been very disruptive, so I've updated this to use `clone` instead to minimize conflicts. It is functionally equivalent. Co-authored-by: Whymarrh Whitby <whymarrh.whitby@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #6547 (comment)
This PR updates how we snapshot
txMetaobjects, cloning them without the history instead of cloning the history and then throwing it away. This should improve the performance ofTransactionStateManager#updateTxwhen the transaction has a particularly large history.There is a test to confirm that the history property is excluded—this is an implementation detail.