Backport "Fix method registry initialization (#8200)" #8459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
backport-fix-method-registry-initialization
branch
from
4eab25d to
d36b004
Compare
Builds ready [d36b004]
|
Gudahtt
force-pushed
the
backport-fix-method-registry-initialization
branch
from
d36b004 to
9eed8e0
Compare
Builds ready [9eed8e0]
|
Backport #8200 to v7.7.9. Original commit description: The method registry was being initialized with the global variable `ethereumProvider` before that variable was set. As a result, the method registry was falling back to an internally constructed provider that used the wrong provider URL (an obsolete Infura API). This was resulting in an error with the message "Project ID not found". The method registry is now initialized lazily, when it's first needed. This should be well after the initialization of `ethereumProvider`, which occurs during the UI initialization.
Gudahtt
force-pushed
the
backport-fix-method-registry-initialization
branch
from
9eed8e0 to
fe30e40
Compare
Builds ready [fe30e40]
|
whymarrh
approved these changes
Apr 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #8200 to v7.7.9. Original commit description:
The method registry was being initialized with the global variable
ethereumProviderbefore that variable was set. As a result, the method registry was falling back to an internally constructed provider that used the wrong provider URL (an obsolete Infura API). This was resulting in an error with the message "Project ID not found".The method registry is now initialized lazily, when it's first needed. This should be well after the initialization of
ethereumProvider, which occurs during the UI initialization.