Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eth-contract-metadata #8466

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Update eth-contract-metadata #8466

merged 1 commit into from
Apr 30, 2020

Conversation

rekmarks
Copy link
Member

Update eth-contract-metadata to 1.13.0

@rekmarks rekmarks requested a review from a team as a code owner April 29, 2020 20:02
whymarrh
whymarrh suggested changes Apr 29, 2020
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
whymarrh
whymarrh previously approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Gudahtt
Gudahtt previously approved these changes Apr 29, 2020
View reviewed changes
@rekmarks rekmarks dismissed stale reviews from Gudahtt and whymarrh via 47af458 April 30, 2020 02:19
@rekmarks rekmarks force-pushed the update-contract-metadata branch from 2fcc910 to 47af458 Compare April 30, 2020 02:19
@rekmarks rekmarks force-pushed the update-contract-metadata branch from 47af458 to eff2b53 Compare April 30, 2020 03:50
@metamaskbot
Copy link
Collaborator

Builds ready [eff2b53]
Page Load Metrics (696 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint307740115
domContentLoaded610102869410752
load612103069610752
domInteractive610102869410752

@rekmarks rekmarks requested review from whymarrh and Gudahtt April 30, 2020 04:10
@metamaskbot
Copy link
Collaborator

Builds ready [eff2b53]
Page Load Metrics (687 ± 19 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint33113472110
domContentLoaded6257636854120
load6277656874019
domInteractive6257636854120

@Gudahtt Gudahtt merged commit 7419fa8 into develop Apr 30, 2020
@Gudahtt Gudahtt deleted the update-contract-metadata branch April 30, 2020 12:50
Gudahtt pushed a commit that referenced this pull request Apr 30, 2020
@rekmarks @Gudahtt
Backport "update eth-contract-metadata (#8466)"
d3e4d73 
Backport #8466 to v7.7.9
@Gudahtt Gudahtt mentioned this pull request Apr 30, 2020
Merged
Gudahtt added a commit that referenced this pull request Apr 30, 2020
@Gudahtt @rekmarks
Backport "update eth-contract-metadata (#8466)" (#8476)
b64cbbd 
Backport #8466 to v7.7.9

Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@whymarrh whymarrh whymarrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rekmarks @metamaskbot @whymarrh @Gudahtt