Fix default gas race condition #8490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends upon #8489 |
|
I do think this solution is sound in principle at least. Though preventing interactions with the transaction in the UI while the default gas is loading would be ideal as well. |
Gudahtt
force-pushed
the
fix-default-gas-race-condition
branch
from
4c764ec to
27b6b2c
Compare
|
seems like we need some rxjs flow that ignores stale values |
Builds ready [27b6b2c]
Page Load Metrics (692 ± 37 ms)
|
Builds ready [27b6b2c]
Page Load Metrics (651 ± 17 ms)
|
Builds ready [27b6b2c]
Page Load Metrics (674 ± 25 ms)
|
Builds ready [27b6b2c]
Page Load Metrics (660 ± 37 ms)
|
Builds ready [27b6b2c]
Page Load Metrics (639 ± 15 ms)
|
Gudahtt
force-pushed
the
fix-default-gas-race-condition
branch
2 times, most recently
from
e67bc95 to
c75b58a
Compare
Gudahtt
changed the base branch from
remove-unnecessary-tx-meta-properties
to
develop
Builds ready [c75b58a]
Page Load Metrics (689 ± 28 ms)
|
whymarrh
suggested changes
May 1, 2020
A race condition exists where after adding an unapproved transaction, it could be mutated and then replaced when the default gas parameters are set. This happens because the transaction is added to state and broadcast before the default gas parameters are set, because calculating the default gas parameters to use takes some time. Once they've been calculated, the false assumption was made that the transaction hadn't changed. The method responsible for setting the default gas now retrieves an up-to-date copy of `txMeta`, and conditionally sets the defaults only if they haven't yet been set. This race condition was introduced in #2962, though that PR also added a loading screen that avoided this issue by preventing the user from interacting with the transaction until after the gas had been estimated. Unfortunately this loading screen was not carried forward to the new UI.
Gudahtt
force-pushed
the
fix-default-gas-race-condition
branch
from
c75b58a to
f00fa8b
Compare
Builds ready [f00fa8b]
Page Load Metrics (646 ± 30 ms)
|
whymarrh
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A race condition exists where after adding an unapproved transaction, it could be mutated and then replaced when the default gas parameters are set. This happens because the transaction is added to state and broadcast before the default gas parameters are set, because calculating the default gas parameters to use takes some time. Once they've been calculated, the false assumption was made that the transaction hadn't changed.
The method responsible for setting the default gas now retrieves an up-to-date copy of
txMeta, and conditionally sets the defaults only if they haven't yet been set.This race condition was introduced in #2962, though that PR also added a loading screen that avoided this issue by preventing the user from interacting with the transaction until after the gas had been estimated. Unfortunately this loading screen was not carried forward to the new UI.