-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ipns address translations #8502
Conversation
FYSA Also, with go-ipfs 0.5 other gateway providers such as Infura are now able to run their own subdomain gateways, as described here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small suggestion
@lidel what does your comment mean for the timeline of this PR? Is that a follow-up change? |
@whymarrh no follow-up is needed, but the feature introduced in this PR won't work until IPFS project updates its DNS to support hostnames under |
Sounds good, thanks |
@hacdias I believe IPNS support is ready: https://dweb.link/ipns/QmPRB9SNEfYaTaZ88VLCpddTYD45B53sC8yH8xYZXGPLJp |
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small suggestions
Co-authored-by: Whymarrh Whitby <whymarrh.whitby@gmail.com>
Co-authored-by: Whymarrh Whitby <whymarrh.whitby@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @hacdias!
We're building up to a version 8 release in the next couple of weeks—this will be part of that |
Hi! 👋
This adds support for IPNS Links which are also part of IPFS spec. The address resolution is exactly the same since they're encoded the same way.
I needed to change the default
ipfsGateway
fromipfs.dweb.link
toipns.dweb.link
which is similar to the defaults of IPFS Companion. I added a migration to replace whatever value the user has there by the new default.This does not add support for DNSLink though. /cc @lidel